OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
33,241 Commits 30 Branches 683 Tags
v15.x
Commit Graph

33241 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Myles Borins
236f958145 Working on v15.14.1 
PR-URL: https://github.com/nodejs/node/pull/38084
 2021-04-06 10:40:01 -04:00
Myles Borins
1a34e9c24b 2021-04-06, Version 15.14.0 (Current) 
Notable Changes:

This is a security release.

Vulnerabilities fixed:

- **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High)
- **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High)
- **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High)

Other Notable changes:

fs:
  * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) https://github.com/nodejs/node/pull/37490
net:
  * (SEMVER-MINOR) allow net.BlockList to use net.SocketAddress objects (James M Snell) https://github.com/nodejs/node/pull/37917
  * (SEMVER-MINOR) add SocketAddress class (James M Snell) https://github.com/nodejs/node/pull/37917
  * (SEMVER-MINOR) make net.BlockList cloneable (James M Snell) https://github.com/nodejs/node/pull/37917
net,tls:
  * (SEMVER-MINOR) add abort signal support to connect (Nitzan Uziely) https://github.com/nodejs/node/pull/37735
readline:
  * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) https://github.com/nodejs/node/pull/37932

PR-URL: https://github.com/nodejs/node/pull/38084
v15.14.0 		2021-04-06 09:28:26 -04:00
Tobias Nießen
629e72e9f4 src: fix typo in node_mutex 
PR-URL: https://github.com/nodejs/node/pull/38011
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-05 12:57:26 -04:00
HiroyukiYagihashi
b6f4901221 fs: add support for async iterators to fsPromises.writeFile 
Fixes: https://github.com/nodejs/node/issues/37391

PR-URL: https://github.com/nodejs/node/pull/37490
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-05 12:57:25 -04:00
Tobias Nießen
e61cc0bfb0 src: fix typos in crypto comments 
PR-URL: https://github.com/nodejs/node/pull/38024
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2021-04-05 12:57:25 -04:00
Filip Skokan
ac69b95e47 crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm name 
PR-URL: https://github.com/nodejs/node/pull/38029
Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-04-05 12:57:25 -04:00
Darkripper214
afc6ab2122 doc: fix asyncLocalStorage.run() description 
The description that store is not available
when asynchronous operation is created within
the callback is not accurate

Fixes: https://github.com/nodejs/node/issues/38022

PR-URL: https://github.com/nodejs/node/pull/38023
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2021-04-05 12:57:25 -04:00
Qingyu Deng
3175559bed test: add extra space in test failure output 
PR-URL: https://github.com/nodejs/node/pull/37957
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-04-05 12:57:25 -04:00
Antoine du Hamel
3ab9619e56 module: improve error message for invalid data URL 
Fixes: https://github.com/nodejs/node/issues/37647

PR-URL: https://github.com/nodejs/node/pull/37701
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-04-05 12:57:24 -04:00
Pooja D P
0243376cfc test: use faster variant for rss 
PR-URL: https://github.com/nodejs/node/pull/36839
Refs: https://github.com/nodejs/node/pull/34291
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-05 12:57:24 -04:00
Anu Pasumarthy
b40d35d649 doc: document how to unref stdin when using readline.Interface 
PR-URL: https://github.com/nodejs/node/pull/38019
Fixes: https://github.com/nodejs/node/issues/36154
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-04-05 12:57:24 -04:00
Richard Lau
b02c352ad6 test: fix test-tls-no-sslv3 for OpenSSL 3 
OpenSSL 3 has changed the format of the error message for an unknown
option to the CLI. Update the test to allow for the older and newer
message formats.

PR-URL: https://github.com/nodejs/node/pull/38027
Refs: https://github.com/openssl/openssl/pull/10774
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-04-05 12:57:24 -04:00
Tobias Nießen
960c6be229 crypto: add buffering to randomInt 
PR-URL: https://github.com/nodejs/node/pull/35110
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-04-05 12:57:24 -04:00
Luigi Pinca
0db1a1eacf test: deflake test-fs-read-optional-params 
If `fs.read()` is called without specifying the `position` option, data
will be read from the current file position. There is another concurrent
`fs.read()` call before the test for no options object which might
invalidate the test expectations.

Run the test for no options object first.

PR-URL: https://github.com/nodejs/node/pull/37991
Fixes: https://github.com/nodejs/node/issues/37946
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-04-05 12:57:23 -04:00
Luigi Pinca
6d28a24f1c tools: update ESLint to 7.23.0 
PR-URL: https://github.com/nodejs/node/pull/37979
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-05 12:57:23 -04:00
Tobias Nießen
6ad0b6f0f5 src: fix error handling for CryptoJob::ToResult 
PR-URL: https://github.com/nodejs/node/pull/37076
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-05 12:57:23 -04:00
Darshan Sen
ad7e34446c fs: fix chown abort 
This syncs the type assertion introduced in the referenced PR in the C++
side. Since chown, lchown, and fchown can accept -1 as a value for uid
and gid, we should also accept signed integers from the JS side.

Fixes: https://github.com/nodejs/node/issues/37995
Refs: https://github.com/nodejs/node/pull/31694

PR-URL: https://github.com/nodejs/node/pull/38004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-05 12:57:23 -04:00
Peter Marshall
ce14080473 doc: move psmarshall to collaborators emeriti 
PR-URL: https://github.com/nodejs/node/pull/37994
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-05 12:57:22 -04:00
Darkripper214
4d50975cd7 test: improve clarity of ALS-enable-disable.js 
The last als.run() will reactivate the als,
hence the test should test for getting the object,
not undefined

PR-URL: https://github.com/nodejs/node/pull/38008
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-04-04 15:27:05 -04:00
James M Snell
0709cbb7fe net: allow net.BlockList to use net.SocketAddress objects 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37917
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-04 15:27:05 -04:00
James M Snell
daa8a7bbcf net: add SocketAddress class 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37917
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-04 15:27:04 -04:00
James M Snell
a4169ce519 net: make net.BlockList cloneable 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37917
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-04 15:27:04 -04:00
Antoine du Hamel
ae70aa3c63 doc: add distinctive color for code elements inside links 
PR-URL: https://github.com/nodejs/node/pull/37950
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-04 15:27:04 -04:00
Akhil Marsonya
8525231902 lib: change wording in lib/domain.js comment 
Change the wording to make the language more Inclusive.

PR-URL: https://github.com/nodejs/node/pull/37933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2021-04-04 15:27:04 -04:00
Akhil Marsonya
21e399be4c lib: change wording in lib/internal/child_process comment 
Change the wording to make the language more Inclusive.

PR-URL: https://github.com/nodejs/node/pull/37903
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 15:27:04 -04:00
Nitzan Uziely
6cc1e15669 readline: fix pre-aborted signal question handling 
fix pre-aborted question handling

PR-URL: https://github.com/nodejs/node/pull/37929
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 15:27:03 -04:00
Nitzan Uziely
a1123f0a29 readline: add AbortSignal support to interface 
Add abort signal support to Interface

PR-URL: https://github.com/nodejs/node/pull/37932
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 15:27:03 -04:00
Nitzan Uziely
669b81c68b net,tls: add abort signal support to connect 
Add documentation for net.connect AbortSignal,
and add the support to tls.connect as well

PR-URL: https://github.com/nodejs/node/pull/37735
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 15:27:03 -04:00
Anna Henningsen
8792c7c96b doc: add missing events.on metadata 
This was missed in the original PR.

Refs: https://github.com/nodejs/node/pull/34912

PR-URL: https://github.com/nodejs/node/pull/37965
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 15:27:03 -04:00
Anna Henningsen
062541aae5 http2: add specific error code for custom frames 
As suggested in
https://github.com/nodejs/node/issues/37849#issuecomment-805049586
improve the error presented when encountering a large number of
invalid frames by giving this situation a specific error code (which we
should have had from the beginning).

PR-URL: https://github.com/nodejs/node/pull/37936
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2021-04-04 15:27:03 -04:00
Antoine du Hamel
51e7a33d54 tools,doc: add "legacy" badge in the TOC 
PR-URL: https://github.com/nodejs/node/pull/37949
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 15:27:03 -04:00
Guy Bedford
4ef102d34e deps: update to cjs-module-lexer@1.1.1 
PR-URL: https://github.com/nodejs/node/pull/37992
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2021-04-04 15:27:02 -04:00
Akhil Marsonya
a94cc27cbe path: refactor to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/37893
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-04-04 15:27:02 -04:00
Michaël Zasso
d86aca9a77 http: optimize debug function correctly 
Exporting a variable that will be mutated later doesn't work.

Refs: https://github.com/nodejs/node/issues/37937

PR-URL: https://github.com/nodejs/node/pull/37966
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-04-04 15:24:04 -04:00
Michaël Zasso
a57dc06adf doc: improve Buffer's encoding documentation 
- Add a paragraph about case-insensitivity of encoding options.
- Document "utf-8", "utf-16le" and "ucs-2" aliases.
- Always use "utf8" in documentation for defaults and examples.

PR-URL: https://github.com/nodejs/node/pull/37945
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-04-04 15:24:04 -04:00
Tobias Nießen
f3fabb57cf doc: add missing cleanup step in OpenSSL upgrade 
Refs: https://github.com/nodejs/node/pull/37916

PR-URL: https://github.com/nodejs/node/pull/37927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2021-04-04 15:22:56 -04:00
Hassaan Pasha
f0e77149a4 deps: update archs files for OpenSSL-1.1.1k 
After an OpenSSL source update, all the config files need to be
 regenerated and committed by:
    $ make -C deps/openssl/config
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/openssl/include/crypto/bn_conf.h
    $ git add deps/openssl/openssl/include/crypto/dso_conf.h
    $ git add deps/openssl/openssl/include/openssl/opensslconf.h
    $ git commit

PR-URL: https://github.com/nodejs/node/pull/37916
Fixes: https://github.com/nodejs/node/issues/37913
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-04 15:22:56 -04:00
Hassaan Pasha
bbdcdad2c6 deps: upgrade openssl sources to 1.1.1k+quic 
This updates all sources in deps/openssl/openssl by:
    $ git clone https://github.com/quictls/openssl
    $ cd openssl
    $ git checkout OpenSSL_1_1_1k+quic
    $ cd ../node/deps/openssl
    $ rm -rf openssl
    $ cp -R ../openssl openssl
    $ cd openssl && rm -rf .gitattributes .github/ .gitmodules .travis-apt-pin.preferences  .travis-create-release.sh
    $ cd ..
    $ git add --all openssl
    $ git commit openssl

PR-URL: https://github.com/nodejs/node/pull/37916
Fixes: https://github.com/nodejs/node/issues/37913
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-04 15:22:55 -04:00
João Lucas Lucchetta
13c3924af8 doc: add Windows-specific info to subprocess.kill() 
Clarify the inner workings of .kill on Windows,
since termination signals are not available there.

Fixes: https://github.com/nodejs/node/issues/34858

PR-URL: https://github.com/nodejs/node/pull/34867
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-04 15:22:55 -04:00
Darshan Sen
570fbcef93 url: forbid pipe in URL host 
Fixes: https://github.com/nodejs/node/issues/37862

PR-URL: https://github.com/nodejs/node/pull/37877
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-04 15:22:54 -04:00
Rich Trott
5e15ae05d0 test: add DataView test case for v8 serdes 
This completes code coverage for v8.js.

Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/v8.js.html#L240

PR-URL: https://github.com/nodejs/node/pull/37955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-04-04 15:22:54 -04:00
pezhmanparsaee
913ec56798 deps: cjs-module-lexer: cherry-pick 22093e765f 
Original commit message:
	fix "the the" typo in README.md file

Refs: 22093e765f

PR-URL: https://github.com/nodejs/node/pull/37895
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2021-04-04 15:22:53 -04:00
Ruy Adorno
22e2ed815b Working on v15.13.1 
PR-URL: https://github.com/nodejs/node/pull/37977
 2021-03-31 10:03:35 -04:00
Ruy Adorno
71a7722243 2021-03-31, Version 15.13.0 (Current) 
PR-URL: https://github.com/nodejs/node/pull/37977

Notable changes:

* buffer:
  * implement btoa and atob (James M Snell) https://github.com/nodejs/node/pull/37529
* deps:
  * upgrade npm to 7.7.6 (Ruy Adorno) https://github.com/nodejs/node/pull/37968
* doc:
  * add legacy status to stability index (James M Snell) https://github.com/nodejs/node/pull/37784
  * add @linkgoron to collaborators (Nitzan Uziely) https://github.com/nodejs/node/pull/37817
* http:
  * add http.ClientRequest.getRawHeaderNames() (simov) https://github.com/nodejs/node/pull/37660
v15.13.0 		2021-03-30 22:19:19 -04:00
Guy Bedford
f09c033faf deps: backport v8 f19142e6 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: f19142e613
PR-URL: https://github.com/nodejs/node/pull/37864
Backport-PR-URL: https://github.com/nodejs/node/pull/37985
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-30 20:40:45 -04:00
Guy Bedford
2fd97ce687 deps: v8 backport 9689b17687b 
[top-level-await] Implement spec fix for cycle root detection

Refs: 9689b17687
PR-URL: https://github.com/nodejs/node/pull/37865
Backport-PR-URL: https://github.com/nodejs/node/pull/37985
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-03-30 20:39:18 -04:00
Ruy Adorno
f2cef54b6f deps: upgrade npm to 7.7.6 
PR-URL: https://github.com/nodejs/node/pull/37968
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-29 21:55:41 -04:00
Rich Trott
b0226b39f2 test: split promisified timers test for coverage purposes 
Because of lazy loading, running promisified timers tests for setTimeout
and setImmediate from the same file means that there is a piece of code
that doesn't get covered. Split into separate files to cover everything.

Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/timers.js.html#L269

PR-URL: https://github.com/nodejs/node/pull/37943
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-03-29 21:55:41 -04:00
Michaël Zasso
e60bd1a7dc perf_hooks: make Performance extend EventTarget 
Refs: https://www.w3.org/TR/hr-time/#sec-performance

PR-URL: https://github.com/nodejs/node/pull/37621
Backport-PR-URL: https://github.com/nodejs/node/pull/37832
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-03-29 20:17:20 -04:00
Rich Trott
d33f446abd util: remove unreachable inspect code 
Convert invariant from if statement to an assertion. The condition is
believed to be impossible to trigger.

PR-URL: https://github.com/nodejs/node/pull/37941
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-03-29 20:17:20 -04:00