OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
32,854 Commits 30 Branches 683 Tags
v14.x
Commit Graph

32854 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Richard Lau
f96f2d4bdd Working on v14.17.5 
PR-URL: https://github.com/nodejs/node/pull/39466
 2021-07-29 10:29:52 -04:00
Richard Lau
488c27f71c 2021-07-29, Version 14.17.4 'Fermium' (LTS) 
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling (High)

This releases fixes some regressions with internationalization
introduced by the ICU updates in Node.js 14.17.0 and 14.17.1.

PR-URL: https://github.com/nodejs/node/pull/39466
v14.17.4 		2021-07-29 05:54:22 -04:00
Darcy Clarke
acf5279c39 deps: upgrade npm to 6.14.14 
PR-URL: https://github.com/nodejs/node/pull/39553
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-07-28 14:39:03 -04:00
Akshay K
d48b91ea2b http2: on receiving rst_stream with cancel code add it to pending list 
PR-URL: https://github.com/nodejs/node/pull/39423
Fixes: https://github.com/nodejs/node/issues/38964
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-07-23 05:48:31 -04:00
Darshan Sen
2ff671e4c4 doc,url: clarify domainTo* when built without ICU 
Continuation of: https://github.com/nodejs/node/pull/35099

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38789
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-07-22 12:06:20 -04:00
Rich Trott
716ee1531c debugger: rename internal library for clarity 
When I moved these files from node-inspect to Node.js core, I put them
in lib/internal/inspector. That was a mistake. They should be in
lib/internal/debugger.

PR-URL: https://github.com/nodejs/node/pull/39080
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-22 12:06:20 -04:00
Rich Trott
b7ee9d8287 debugger: use ERR_DEBUGGER_STARTUP_ERROR in _inspect.js 
PR-URL: https://github.com/nodejs/node/pull/39024
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-07-22 12:06:19 -04:00
Rich Trott
9b993edca8 errors: add ERR_DEBUGGER_STARTUP_ERROR 
PR-URL: https://github.com/nodejs/node/pull/39024
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-07-22 12:06:19 -04:00
Rich Trott
5d4d23dcf3 debugger: use error codes in debugger REPL 
PR-URL: https://github.com/nodejs/node/pull/39024
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-07-22 12:06:19 -04:00
Rich Trott
a3991d7c18 debugger: use ERR_DEBUGGER_ERROR in debugger client 
PR-URL: https://github.com/nodejs/node/pull/39024
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-07-22 12:06:19 -04:00
Rich Trott
cfccf13e84 errors: add ERR_DEBUGGER_ERROR 
PR-URL: https://github.com/nodejs/node/pull/39024
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-07-22 12:06:19 -04:00
Rich Trott
052e1c5385 debugger: removed unused function argument 
PR-URL: https://github.com/nodejs/node/pull/38850
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:18 -04:00
Antoine du Hamel
f9a4dcb30c debugger: refactor inspect_repl to use primordials 
PR-URL: https://github.com/nodejs/node/pull/38551
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:18 -04:00
Antoine du Hamel
ad8056659f debugger: refactor to use internal modules 
This avoids loading the entirety of `node:util` and `node:url` and their
dependencies while only a subset is actually used by this module.

PR-URL: https://github.com/nodejs/node/pull/38550
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-07-22 12:06:18 -04:00
Rich Trott
b5724a1984 debugger: disable only the lint rules required by current file state 
PR-URL: https://github.com/nodejs/node/pull/38529
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:18 -04:00
Rich Trott
34659f2b7a debugger: avoid non-ASCII char in code file 
Avoid non-ASCII char in lib code as a single non-ASCII char forces all
the chars to be stored inefficiently, bloating the binary size. This
also brings the file closer to compatibility with our lint rules.

PR-URL: https://github.com/nodejs/node/pull/38529
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:17 -04:00
Rich Trott
ae90756582 debugger: wrap lines longer than 80 chars 
Wrap lines more than 80 chararcters long in inspect_repl.js so we can
disable specific rules.

PR-URL: https://github.com/nodejs/node/pull/38529
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:17 -04:00
Rich Trott
b30ff35a36 debugger: align message with Node.js standard 
Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the
messages from inspect with other messages from the REPL and elsewhere,
make that change in node-inspect too.

PR-URL: https://github.com/nodejs/node/pull/38400
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:17 -04:00
Rich Trott
d74d67f207 debugger: remove unnecessary boilerplate copyright comment 
PR-URL: https://github.com/nodejs/node/pull/38952
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-22 12:06:17 -04:00
Antoine du Hamel
e58f938ab3 debugger: enable linter on internal/inspector/inspect_client 
PR-URL: https://github.com/nodejs/node/pull/38417
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-22 12:06:17 -04:00
Rich Trott
249acd5e69 debugger: reduce scope of eslint disable comment 
Current code masks setInterval and setTimeout with promisified versions.
This can be confusing to read and causes lint errors. Replace masking
with use of pSetInterval and pSetTimeout instead.

Move disabling of lint rule from entire file to the one remaining line
(after the above changes) that still needs it.

PR-URL: https://github.com/nodejs/node/pull/38946
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-22 12:06:16 -04:00
Rich Trott
0ef5e088c0 debugger: revise async iterator usage to comply with lint rules 
I'm not sure that this is any clearer than the existing code, but I
don't think it's significantly less clear, and it avoids comment
disabling a lint rule.

PR-URL: https://github.com/nodejs/node/pull/38847
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:16 -04:00
Michaël Zasso
79bfb0416b debugger: wait for V8 debugger to be enabled 
Refs: https://github.com/nodejs/node/pull/38273#issuecomment-848438189

PR-URL: https://github.com/nodejs/node/pull/38811
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-22 12:06:16 -04:00
Antoine du Hamel
721edeffd3 debugger: refactor internal/inspector/_inspect to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/38406
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-22 12:06:16 -04:00
Rafael Gonzaga
21ecee1b4b debugger: add usage example for --port 
PR-URL: https://github.com/nodejs/node/pull/38400
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-22 12:06:16 -04:00
Antoine du Hamel
cde72213d1 Revert "debugger: rename internal library for clarity" 
This reverts commit d0c7ab00f9fcbf6ba45c3f554fa75cf60ca1b2ce.

PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-07-22 12:06:15 -04:00
Antoine du Hamel
d8cc2fffd6 lib: add primordials.SafeArrayIterator 
PR-URL: https://github.com/nodejs/node/pull/36532
Backport-PR-URL: https://github.com/nodejs/node/pull/39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-22 12:06:15 -04:00
Michaël Zasso
4efefe02a8 deps: V8: backport ae7bfb3f03b3 
Original commit message:

    Change test expectation per tz2020b

    https://mm.icann.org/pipermail/tz-announce/2020-October/000059.html
         Revised predictions for Morocco's changes starting in 2023.
         Canada's Yukon changes to -07 on 2020-11-01, not 2020-03-08.
         Macquarie Island has stayed in sync with Tasmania since 2011.
         Casey, Antarctica is at +08 in winter and +11 in summer.
         zic no longer supports -y, nor the TYPE field of Rules.

    Bug: chromium:1137864, chromium:1138117
    Change-Id: I6076a993fcd755074ddcfa5321b78aa5f043337b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2476681
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70553}

Refs: ae7bfb3f03

PR-URL: https://github.com/nodejs/node/pull/39051
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-07-20 07:11:43 -04:00
Michaël Zasso
5039f21396 deps: V8: backport 16ffec97e5eb 
Original commit message:

    Fix maximize/minimize of Intl.Locale

    Roll ICU to 46f53dfc
    chromium/src/DEPS already roll in https://chromium-review.googlesource.com/c/chromium/src/+/2235734

    Bug: v8:10448
    Change-Id: I147189527e57282c6cc7a1e92f832275d5ef55c6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237353
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68275}

Refs: 16ffec97e5

PR-URL: https://github.com/nodejs/node/pull/39051
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-07-20 07:11:42 -04:00
Richard Lau
45c2ea3b72 test: add NumberFormat resolvedOptions test 
Add a regression test for NumberFormat resolvedOptions.

PR-URL: https://github.com/nodejs/node/pull/39401
Refs: https://github.com/nodejs/node/issues/39050
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Backport-PR-URL: https://github.com/nodejs/node/pull/39051
 2021-07-20 07:11:42 -04:00
Michaël Zasso
9b69069f71 deps: V8: cherry-pick b0a7f5691113 
Original commit message:

    Update to ICU68-1

    ICU68-1 change the output skeleton format. So we need to change
    resolvedOptions code for 68 migration.

    Chromium roll
    https://chromium-review.googlesource.com/c/chromium/src/+/2474093

    Bug: v8:10945
    Change-Id: I3b2c7fbe8abb22df8fa51287c498ca3245b8c55b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477431
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70972}

Refs: b0a7f56911

PR-URL: https://github.com/nodejs/node/pull/39051
Fixes: https://github.com/nodejs/node/issues/39050
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-07-20 07:11:42 -04:00
Antoine du Hamel
e3223edb89 lib: harden lint checks for globals 
PR-URL: https://github.com/nodejs/node/pull/38419
Backport-PR-URL: https://github.com/nodejs/node/pull/39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-07-20 07:11:42 -04:00
Antoine du Hamel
d4f96bb926 lib: enforce using primordials.globalThis instead of global 
PR-URL: https://github.com/nodejs/node/pull/38230
Backport-PR-URL: https://github.com/nodejs/node/pull/39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-20 07:11:41 -04:00
Antoine du Hamel
ea9003a559 lib: add globalThis to primordials 
PR-URL: https://github.com/nodejs/node/pull/38211
Backport-PR-URL: https://github.com/nodejs/node/pull/39448
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-20 07:11:41 -04:00
Momtchil Momtchev
1ab4f81abc build: fix building with external builtins 
PR-URL: https://github.com/nodejs/node/pull/39091
Backport-PR-URL: https://github.com/nodejs/node/pull/39419
Fixes: https://github.com/nodejs/node/issues/39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-20 07:11:41 -04:00
Darshan Sen
e7f266e93d src: use SPrintF in ProcessEmitWarning 
PR-URL: https://github.com/nodejs/node/pull/38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: https://github.com/nodejs/node/pull/39419
 2021-07-20 07:11:40 -04:00
bcoe
bb9a9adc2b errors: don't rekey on primitive type 
If an error is thrown before a module is loaded, we attempt to cache
source map against error object, rather than module object. We
can't do this if the error is a primitive type

Fixes #38945

PR-URL: https://github.com/nodejs/node/pull/39025
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-07-20 07:11:40 -04:00
Rich Trott
ab45ace9bd tools: update babel-eslint-parser to 7.14.5 
PR-URL: https://github.com/nodejs/node/pull/39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-20 07:11:40 -04:00
Rich Trott
097a7874d3 lib: remove semicolon in preparation for babel/eslint-parser update 
eslint-babel-plugin will complain about this semicolon when we update
to 7.14.15.

PR-URL: https://github.com/nodejs/node/pull/39094
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-20 07:11:39 -04:00
Rich Trott
b8e63b3c08 tools: update ESLint to 7.29.0 
PR-URL: https://github.com/nodejs/node/pull/39083
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-20 07:11:39 -04:00
Joyee Cheung
199fe32cbc lib: make internal/options lazy 
This way, internal modules can still require the module
and cache the function getOptionValue() early (therefore
these code can be included in the snapshots), but the
options map won't be serialized from C++ land until the
option values are actually queried.

PR-URL: https://github.com/nodejs/node/pull/38993
Refs: https://github.com/nodejs/node/issues/35711
Refs: https://github.com/nodejs/node/pull/38905
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-20 07:11:39 -04:00
Joyee Cheung
a657f250f1 build: reconfigure when gyp files change on Windows 
Previously only changes to .gypi files trigger a reconfigure
on Windows.

PR-URL: https://github.com/nodejs/node/pull/39066
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-07-20 07:11:38 -04:00
Rich Trott
4c2b813799 debugger: rename internal library for clarity 
When I moved these files from node-inspect to Node.js core, I put them
in lib/internal/inspector. That was a mistake. They should be in
lib/internal/debugger.

PR-URL: https://github.com/nodejs/node/pull/39080
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-20 07:11:38 -04:00
Rich Trott
6b2fea38d1 test: move inspector-cli tests to sequential 
There's no reason to keep these tests separated from everything else.

PR-URL: https://github.com/nodejs/node/pull/39079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-20 07:11:38 -04:00
Rongjian Zhang
6447cab7be test: improve buffer coverage 
PR-URL: https://github.com/nodejs/node/pull/38538
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-20 07:11:38 -04:00
Voltrex
2bc2a232af lib: add JSDoc typings for child_process 
Added JSDoc typings for the `child_process` lib module.

PR-URL: https://github.com/nodejs/node/pull/38222
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-07-20 07:11:37 -04:00
devsnek
04032fa1a3 doc: remove references to deleted freenode channels 
PR-URL: https://github.com/nodejs/node/pull/39047
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2021-07-20 07:11:37 -04:00
XadillaX
51da7d2048 src,url: separate some tables out of node_url.cc 
The purpose of separating is for readability and maintainability.

PR-URL: https://github.com/nodejs/node/pull/38988
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2021-07-20 07:11:37 -04:00
legendecas
43fe6c1d27 src: cleanup uv_fs_t regardless of success or not 
PR-URL: https://github.com/nodejs/node/pull/38996
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2021-07-20 07:11:37 -04:00
Tobias Nießen
6f1862eab3 test: fix name of variable in inspector-cli test 
PR-URL: https://github.com/nodejs/node/pull/38869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-20 07:11:36 -04:00