OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

readline: replace _questionCancel with a symbol

Browse Source 
This commit avoids exposing a new underscored property on
readline Interface instances.

PR-URL: https://github.com/nodejs/node/pull/37094
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig
2021-01-26 22:42:13 -05:00
committed by ZiJian Liu
parent b02030df00
commit fec093b6b7
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/readline.js
View File

@@ -117,6 +117,7 @@ const kMincrlfDelay = 100;
const lineEnding = /\r?\n|\r(?!\n)/;
const kLineObjectStream = Symbol('line object stream');
const kQuestionCancel = Symbol('kQuestionCancel');
const KEYPRESS_DECODER = Symbol('keypress-decoder');
const ESCAPE_DECODER = Symbol('escape-decoder');
@@ -225,7 +226,7 @@ function Interface(input, output, completer, terminal) {
};
}
this._questionCancel = FunctionPrototypeBind(_questionCancel, this);
this[kQuestionCancel] = FunctionPrototypeBind(_questionCancel, this);
this.setPrompt(prompt);
@@ -376,7 +377,7 @@ Interface.prototype.question = function(query, options, cb) {
if (options.signal) {
options.signal.addEventListener('abort', () => {
this._questionCancel();
this[kQuestionCancel]();
}, { once: true });
}