OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot

Browse Source 
Otherwise the build would fail with
`./configure --experimental-quic --ninja` as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See https://github.com/nodejs/node/issues/31074.

PR-URL: https://github.com/nodejs/node/pull/34454
Fixes: https://github.com/nodejs/node/issues/34435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This commit is contained in:
Joyee Cheung
2020-07-21 08:56:47 +08:00
committed by gengjiawen
parent 07b3aae04e
commit f4f191bbc2
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
node.gyp
View File

@@ -1376,6 +1376,11 @@
'HAVE_OPENSSL=1',
],
}],
[ 'node_use_openssl=="true" and experimental_quic==1', {
'defines': [
'NODE_EXPERIMENTAL_QUIC=1',
],
}],
['v8_enable_inspector==1', {
'defines': [
'HAVE_INSPECTOR=1',
@@ -1430,6 +1435,11 @@
'HAVE_OPENSSL=1',
],
}],
[ 'node_use_openssl=="true" and experimental_quic==1', {
'defines': [
'NODE_EXPERIMENTAL_QUIC=1',
],
}],
['v8_enable_inspector==1', {
'defines': [
'HAVE_INSPECTOR=1',