OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

meta: edit collaborator nomination process

Browse Source 
- recommend more strongly a private discussion prior to a public one.
- add requirement for the nominee to publicly accept the nomination.
- move recommendation for heads up comment from "How to review
  nominations" section to "Nominating new Collaborator" section.

PR-URL: https://github.com/nodejs/node/pull/57483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
This commit is contained in:
Antoine du Hamel
2025-03-19 21:06:12 +01:00
committed by GitHub
parent 9851388468
commit ea9be17872
1 changed files with 28 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
GOVERNANCE.md
View File

@@ -146,8 +146,31 @@ Contributions can be:
### Nominating a new Collaborator
To nominate a new Collaborator, open an issue in the [nodejs/node][] repository.
Provide a summary of the nominee's contributions. For example:
To nominate a new Collaborator:
1. **Optional but strongly recommended**: open a
[discussion in the nodejs/collaborators][] repository. Provide a summary of
the nominee's contributions (see below for an example).
2. **Optional but strongly recommended**: After sufficient wait time (e.g. 72
hours), if the nomination proposal has received some support and no explicit
block, add a comment in the private discussion stating you're planning on
opening a public issue, e.g. "I see a number of approvals and no block, I'll
be opening a public nomination issue if I don't hear any objections in the
next 72 hours".
3. **Optional but strongly recommended**: Privately contact the nominee to make
sure they're comfortable with the nomination.
4. Open an issue in the [nodejs/node][] repository. Provide a summary of
the nominee's contributions (see below for an example). Mention
@nodejs/collaborators in the issue to notify other collaborators about
the nomination.
The _Optional but strongly recommended_ steps are optional in the sense that
skipping them would not invalidate the nomination, but it could put the nominee
in a very awkward situation if a nomination they didn't ask for pops out of
nowhere only to be rejected. Do not skip those steps unless you're absolutely
certain the nominee is fine with the public scrutiny.
Example of list of contributions:
* Commits in the [nodejs/node][] repository.
* Use the link `https://github.com/nodejs/node/commits?author=GITHUB_ID`
@@ -166,19 +189,11 @@ Provide a summary of the nominee's contributions. For example:
organization
* Other participation in the wider Node.js community
Mention @nodejs/collaborators in the issue to notify other collaborators about
the nomination.
The nomination passes if no collaborators oppose it after one week. In the case
The nomination passes if no collaborators oppose it after one week, and if the
nominee publicly accepts it. In the case
of an objection, the TSC is responsible for working with the individuals
involved and finding a resolution.
There are steps a nominator can take in advance to make a nomination as
frictionless as possible. To request feedback from other collaborators in
private, use the [collaborators discussion page][]
(which only collaborators may view). A nominator may also work with the
nominee to improve their contribution profile.
Collaborators might overlook someone with valuable contributions. In that case,
the contributor may open an issue or contact a collaborator to request a
nomination.
@@ -206,11 +221,6 @@ push commits, etc.), so what's the minimal amount is subjective, and there will
be cases where collaborators disagree on whether a nomination should move
forward.
When concerns have been raised on the private discussion, refrain from opening
the public issue. If no one has explicitly blocked the nomination and you'd like
it to move forward, comment something like "If I don't hear any objections
before (some time), I will open the public issue".
### Onboarding
After the nomination passes, a TSC member onboards the new collaborator. See
@@ -224,6 +234,6 @@ The TSC follows a [Consensus Seeking][] decision-making model per the
[Consensus Seeking]: https://en.wikipedia.org/wiki/Consensus-seeking_decision-making
[TSC Charter]: https://github.com/nodejs/TSC/blob/HEAD/TSC-Charter.md
[collaborators discussion page]: https://github.com/nodejs/collaborators/discussions/categories/collaborator-nominations
[discussion in the nodejs/collaborators]: https://github.com/nodejs/collaborators/discussions/categories/collaborator-nominations
[nodejs/help]: https://github.com/nodejs/help
[nodejs/node]: https://github.com/nodejs/node