OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

stream: Remove unnecessary nextTick usage in Writable

Browse Source 
Fix #4928
This commit is contained in:
isaacs
2013-03-05 17:53:37 -08:00
parent 32ac8c0b69
commit e0cec37d50
1 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
lib/_stream_writable.js
View File

@@ -240,31 +240,35 @@ function onwrite(stream, er) {
if (er)
onwriteError(stream, state, sync, er, cb);
else {
if (!finishMaybe(stream, state)) {
if (state.length === 0 && state.needDrain)
onwriteDrain(stream, state);
var finished = finishMaybe(stream, state);
if (!state.bufferProcessing && state.buffer.length)
clearBuffer(stream, state);
if (!finished && !state.bufferProcessing && state.buffer.length)
clearBuffer(stream, state);
if (sync) {
process.nextTick(function() {
afterWrite(stream, state, finished, cb);
});
} else {
afterWrite(stream, state, finished, cb);
}
if (sync)
process.nextTick(cb);
else
cb();
}
}
function afterWrite(stream, state, finished, cb) {
if (!finished)
onwriteDrain(stream, state);
cb();
}
// Must force callback to be called on nextTick, so that we don't
// emit 'drain' before the write() consumer gets the 'false' return
// value, and has a chance to attach a 'drain' listener.
function onwriteDrain(stream, state) {
process.nextTick(function() {
if (state.needDrain) {
state.needDrain = false;
stream.emit('drain');
}
});
if (state.length === 0 && state.needDrain) {
state.needDrain = false;
stream.emit('drain');
}
}