OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

child_process: refactor to use validateBoolean

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/38927
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Qingyu Deng
2021-06-04 17:49:04 +08:00
committed by James M Snell
parent 7727dd5bee
commit e0238c4352
1 changed files with 8 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/child_process.js
View File

@@ -75,6 +75,7 @@ const { getValidatedPath } = require('internal/fs/utils');
const {
isInt32,
validateAbortSignal,
validateBoolean,
validateObject,
validateString,
} = require('internal/validators');
@@ -459,10 +460,8 @@ function normalizeSpawnArguments(file, args, options) {
}
// Validate detached, if present.
if (options.detached != null &&
typeof options.detached !== 'boolean') {
throw new ERR_INVALID_ARG_TYPE('options.detached',
'boolean', options.detached);
if (options.detached != null) {
validateBoolean(options.detached, 'options.detached');
}
// Validate the uid, if present.
@@ -489,19 +488,15 @@ function normalizeSpawnArguments(file, args, options) {
}
// Validate windowsHide, if present.
if (options.windowsHide != null &&
typeof options.windowsHide !== 'boolean') {
throw new ERR_INVALID_ARG_TYPE('options.windowsHide',
'boolean', options.windowsHide);
if (options.windowsHide != null) {
validateBoolean(options.windowsHide, 'options.windowsHide');
}
// Validate windowsVerbatimArguments, if present.
let { windowsVerbatimArguments } = options;
if (windowsVerbatimArguments != null &&
typeof windowsVerbatimArguments !== 'boolean') {
throw new ERR_INVALID_ARG_TYPE('options.windowsVerbatimArguments',
'boolean',
windowsVerbatimArguments);
if (windowsVerbatimArguments != null) {
validateBoolean(windowsVerbatimArguments,
'options.windowsVerbatimArguments');
}
if (options.shell) {