OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: improve coverage of fs internal utils

Browse Source 
Refs: https://coverage.nodejs.org/coverage-910efc2d9a69ac32/lib/internal/fs/utils.js.html#L634

PR-URL: https://github.com/nodejs/node/pull/38746
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rongjian Zhang
2021-05-20 21:01:53 +08:00
committed by XadillaX
parent 2bb0c2013f
commit def57580fc
2 changed files with 87 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

87
test/parallel/test-fs-util-validateoffsetlength.js Normal file
View File

@@ -0,0 +1,87 @@
// Flags: --expose-internals
'use strict';
const common = require('../common');
const assert = require('assert');
const {
validateOffsetLengthRead,
validateOffsetLengthWrite,
} = require('internal/fs/utils');
{
const offset = -1;
assert.throws(
() => validateOffsetLengthRead(offset, 0, 0),
common.expectsError({
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "offset" is out of range. ' +
`It must be >= 0. Received ${offset}`
})
);
}
{
const length = -1;
assert.throws(
() => validateOffsetLengthRead(0, length, 0),
common.expectsError({
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "length" is out of range. ' +
`It must be >= 0. Received ${length}`
})
);
}
{
const offset = 1;
const length = 1;
const byteLength = offset + length - 1;
assert.throws(
() => validateOffsetLengthRead(offset, length, byteLength),
common.expectsError({
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "length" is out of range. ' +
`It must be <= ${byteLength - offset}. Received ${length}`
})
);
}
// Most platforms don't allow reads or writes >= 2 GB.
// See https://github.com/libuv/libuv/pull/1501.
const kIoMaxLength = 2 ** 31 - 1;
// RangeError when offset > byteLength
{
const offset = 100;
const length = 100;
const byteLength = 50;
assert.throws(
() => validateOffsetLengthWrite(offset, length, byteLength),
common.expectsError({
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "offset" is out of range. ' +
`It must be <= ${byteLength}. Received ${offset}`
})
);
}
// RangeError when byteLength < kIoMaxLength, and length > byteLength - offset.
{
const offset = kIoMaxLength - 150;
const length = 200;
const byteLength = kIoMaxLength - 100;
assert.throws(
() => validateOffsetLengthWrite(offset, length, byteLength),
common.expectsError({
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "length" is out of range. ' +
`It must be <= ${byteLength - offset}. Received ${length}`
})
);
}

43
test/parallel/test-fs-util-validateoffsetlengthwrite.js
View File

@@ -1,43 +0,0 @@
// Flags: --expose-internals
'use strict';
require('../common');
const assert = require('assert');
const { validateOffsetLengthWrite } = require('internal/fs/utils');
// Most platforms don't allow reads or writes >= 2 GB.
// See https://github.com/libuv/libuv/pull/1501.
const kIoMaxLength = 2 ** 31 - 1;
// RangeError when offset > byteLength
{
const offset = 100;
const length = 100;
const byteLength = 50;
assert.throws(
() => validateOffsetLengthWrite(offset, length, byteLength),
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "offset" is out of range. ' +
`It must be <= ${byteLength}. Received ${offset}`
}
);
}
// RangeError when byteLength < kIoMaxLength, and length > byteLength - offset.
{
const offset = kIoMaxLength - 150;
const length = 200;
const byteLength = kIoMaxLength - 100;
assert.throws(
() => validateOffsetLengthWrite(offset, length, byteLength),
{
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
message: 'The value of "length" is out of range. ' +
`It must be <= ${byteLength - offset}. Received ${length}`
}
);
}