src: run RunBeforeExitCallbacks as part of EmitBeforeExit

This is part of a series of changes to make embedding easier, by
requiring fewer internal methods to build a fully functioning
Node.js instance.

This also aligns the worker_threads code with the main thread code.

PR-URL: https://github.com/nodejs/node/pull/30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This commit is contained in:
Anna Henningsen
2019-11-02 21:11:40 +01:00
parent 86cdfc60a9
commit d4b2cc7ead
2 changed files with 2 additions and 2 deletions

View File

@@ -30,6 +30,8 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) {
}
void EmitBeforeExit(Environment* env) {
env->RunBeforeExitCallbacks();
HandleScope handle_scope(env->isolate());
Context::Scope context_scope(env->context());
Local<Value> exit_code = env->process_object()

View File

@@ -140,8 +140,6 @@ int NodeMainInstance::Run() {
more = uv_loop_alive(env->event_loop());
if (more && !env->is_stopping()) continue;
env->RunBeforeExitCallbacks();
if (!uv_loop_alive(env->event_loop())) {
EmitBeforeExit(env.get());
}