mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
src: run RunBeforeExitCallbacks as part of EmitBeforeExit
This is part of a series of changes to make embedding easier, by requiring fewer internal methods to build a fully functioning Node.js instance. This also aligns the worker_threads code with the main thread code. PR-URL: https://github.com/nodejs/node/pull/30229 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
This commit is contained in:
@@ -30,6 +30,8 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) {
|
||||
}
|
||||
|
||||
void EmitBeforeExit(Environment* env) {
|
||||
env->RunBeforeExitCallbacks();
|
||||
|
||||
HandleScope handle_scope(env->isolate());
|
||||
Context::Scope context_scope(env->context());
|
||||
Local<Value> exit_code = env->process_object()
|
||||
|
||||
@@ -140,8 +140,6 @@ int NodeMainInstance::Run() {
|
||||
more = uv_loop_alive(env->event_loop());
|
||||
if (more && !env->is_stopping()) continue;
|
||||
|
||||
env->RunBeforeExitCallbacks();
|
||||
|
||||
if (!uv_loop_alive(env->event_loop())) {
|
||||
EmitBeforeExit(env.get());
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user