mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
deps: V8: cherry-pick 2a0bc36dec12
Original commit message:
[parser] Fix the MSVC build
MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString
method despite it being unused. This CL adds an (unreachable)
definition for it.
Bug: v8:12266
Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77313}
Refs: 2a0bc36dec
PR-URL: https://github.com/nodejs/node/pull/40178
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
@@ -36,7 +36,7 @@
|
||||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.9',
|
||||
'v8_embedder_string': '-node.10',
|
||||
|
||||
##### V8 defaults for Node.js #####
|
||||
|
||||
|
||||
7
deps/v8/src/parsing/parser.h
vendored
7
deps/v8/src/parsing/parser.h
vendored
@@ -709,6 +709,13 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
|
||||
return arg;
|
||||
}
|
||||
|
||||
const AstRawString* PreParserIdentifierToAstRawString(
|
||||
const PreParserIdentifier& arg) {
|
||||
// This method definition is only needed due to an MSVC oddity that
|
||||
// instantiates the method despite it being unused. See crbug.com/v8/12266 .
|
||||
UNREACHABLE();
|
||||
}
|
||||
|
||||
IterationStatement* AsIterationStatement(BreakableStatement* s) {
|
||||
return s->AsIterationStatement();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user