OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

http: remove variable redeclaration

Browse Source 
In lib/_http_client.js, the variable `conn` was declared with the `var`
keyword three times in the same scope. This change eliminates the
variable entirely.

PR-URL: https://github.com/nodejs/node/pull/4612
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott
2016-01-10 14:17:36 -08:00
committed by James M Snell
parent 53cc9785ab
commit bbaf0f926d
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/_http_client.js
View File

@@ -121,8 +121,7 @@ function ClientRequest(options, cb) {
if (self.socketPath) {
self._last = true;
self.shouldKeepAlive = false;
var conn = self.agent.createConnection({ path: self.socketPath });
self.onSocket(conn);
self.onSocket(self.agent.createConnection({ path: self.socketPath }));
} else if (self.agent) {
// If there is an agent we should default to Connection:keep-alive,
// but only if the Agent will actually reuse the connection!
@@ -141,12 +140,11 @@ function ClientRequest(options, cb) {
self._last = true;
self.shouldKeepAlive = false;
if (options.createConnection) {
var conn = options.createConnection(options);
self.onSocket(options.createConnection(options));
} else {
debug('CLIENT use net.createConnection', options);
var conn = net.createConnection(options);
self.onSocket(net.createConnection(options));
}
self.onSocket(conn);
}
self._deferToConnect(null, null, function() {