OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: reduce http-server-request-timeouts-mixed flakiness

Browse Source 
parallel/test-http-server-request-timeouts-mixed.js test was sometimes
failing due to insufficient tolerance between the connection timeout
checking interval, and the expected timeout specified in the test.

This change makes the checking interval more frequent, and decouples
the timeout for the check from the checking interval.

PR-URL: https://github.com/nodejs/node/pull/44169
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Nick Sia
2022-08-08 18:09:17 +08:00
committed by Luigi Pinca
parent eefe553026
commit b84a6338b4
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/parallel/test-http-server-request-timeouts-mixed.js
View File

@@ -15,7 +15,7 @@ const responseOk = 'HTTP/1.1 200 OK\r\n';
const responseTimeout = 'HTTP/1.1 408 Request Timeout\r\n';
const headersTimeout = common.platformTimeout(2000);
const connectionsCheckingInterval = headersTimeout / 4;
const connectionsCheckingInterval = headersTimeout / 8;
const server = createServer({
headersTimeout,
@@ -76,7 +76,8 @@ server.listen(0, common.mustCall(() => {
// Send the second request, stop in the middle of the headers
request2.client.write(requestBodyPart1);
// Send the second request, stop in the middle of the headers
// Send the third request and stop in the middle of the headers
request3.client.write(requestBodyPart1);
}, headersTimeout * 0.2);
@@ -111,7 +112,7 @@ server.listen(0, common.mustCall(() => {
assert(request1.response.startsWith(responseOk));
assert(request2.response.startsWith(responseTimeout)); // It is expired due to headersTimeout
}, headersTimeout * 1.2 + connectionsCheckingInterval);
}, headersTimeout * 1.4);
setTimeout(() => {
// Complete the body for the fourth request