OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

tty: refactor to avoid unsafe array iteration

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/36771
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
This commit is contained in:
Antoine du Hamel
2020-12-31 12:40:50 +01:00
parent 08d8958a35
commit b12127a939
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/internal/tty.js
View File

@@ -23,6 +23,7 @@
'use strict';
const {
ArrayPrototypeSome,
RegExpPrototypeTest,
StringPrototypeSplit,
StringPrototypeToLowerCase,
@@ -202,10 +203,9 @@ function getColorDepth(env = process.env) {
if (TERM_ENVS[termEnv]) {
return TERM_ENVS[termEnv];
}
for (const term of TERM_ENVS_REG_EXP) {
if (RegExpPrototypeTest(term, termEnv)) {
return COLORS_16;
}
if (ArrayPrototypeSome(TERM_ENVS_REG_EXP,
(term) => RegExpPrototypeTest(term, termEnv))) {
return COLORS_16;
}
}
// Move 16 color COLORTERM below 16m and 256

2
lib/tty.js
View File

@@ -132,7 +132,7 @@ WriteStream.prototype._refreshSize = function() {
this.emit('error', errors.errnoException(err, 'getWindowSize'));
return;
}
const [newCols, newRows] = winSize;
const { 0: newCols, 1: newRows } = winSize;
if (oldCols !== newCols || oldRows !== newRows) {
this.columns = newCols;
this.rows = newRows;