OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: use mustSucceed instead of mustCall with assert.ifError

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/43188
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
This commit is contained in:
MURAKAMI Masahiko
2022-05-24 08:29:43 +09:00
committed by GitHub
parent 360cda1926
commit ac4ea6207e
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-fs-options-immutable.js
View File

@@ -6,19 +6,17 @@ const common = require('../common');
//
// Refer: https://github.com/nodejs/node/issues/7655
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const errHandler = (e) => assert.ifError(e);
const options = Object.freeze({});
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();
fs.readFile(__filename, options, common.mustCall(errHandler));
fs.readFile(__filename, options, common.mustSucceed());
fs.readFileSync(__filename, options);
fs.readdir(__dirname, options, common.mustCall(errHandler));
fs.readdir(__dirname, options, common.mustSucceed());
fs.readdirSync(__dirname, options);
if (common.canCreateSymLink()) {
@@ -28,20 +26,20 @@ if (common.canCreateSymLink()) {
fs.writeFileSync(sourceFile, '');
fs.symlinkSync(sourceFile, linkFile);
fs.readlink(linkFile, options, common.mustCall(errHandler));
fs.readlink(linkFile, options, common.mustSucceed());
fs.readlinkSync(linkFile, options);
}
{
const fileName = path.resolve(tmpdir.path, 'writeFile');
fs.writeFileSync(fileName, 'ABCD', options);
fs.writeFile(fileName, 'ABCD', options, common.mustCall(errHandler));
fs.writeFile(fileName, 'ABCD', options, common.mustSucceed());
}
{
const fileName = path.resolve(tmpdir.path, 'appendFile');
fs.appendFileSync(fileName, 'ABCD', options);
fs.appendFile(fileName, 'ABCD', options, common.mustCall(errHandler));
fs.appendFile(fileName, 'ABCD', options, common.mustSucceed());
}
if (!common.isIBMi) { // IBMi does not support fs.watch()
@@ -56,13 +54,13 @@ if (!common.isIBMi) { // IBMi does not support fs.watch()
{
fs.realpathSync(__filename, options);
fs.realpath(__filename, options, common.mustCall(errHandler));
fs.realpath(__filename, options, common.mustSucceed());
}
{
const tempFileName = path.resolve(tmpdir.path, 'mkdtemp-');
fs.mkdtempSync(tempFileName, options);
fs.mkdtemp(tempFileName, options, common.mustCall(errHandler));
fs.mkdtemp(tempFileName, options, common.mustSucceed());
}
{