OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

module: validate request in require.resolve.paths

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/18359
Fixes: https://github.com/nodejs/node/issues/18352
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Joyee Cheung
2018-01-25 04:56:15 +08:00
parent d4dd0665f5
commit 9fb91fe1d6
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/internal/module.js
View File

@@ -27,6 +27,10 @@ function makeRequireFunction(mod) {
require.resolve = resolve;
function paths(request) {
if (typeof request !== 'string') {
throw new errors.Error('ERR_INVALID_ARG_TYPE',
'request', 'string', request);
}
return Module._resolveLookupPaths(request, mod, true);
}

7
test/parallel/test-require-resolve.js
View File

@@ -47,4 +47,11 @@ const re = /^The "request" argument must be of type string\. Received type \w+$/
code: 'ERR_INVALID_ARG_TYPE',
message: re
});
common.expectsError(
() => { require.resolve.paths(value); },
{
code: 'ERR_INVALID_ARG_TYPE',
message: re
});
});