mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
Bugfix: Trap exceptions in URIParser.
A user was able to crash chat.tinyclouds.org by sending it a malformed URL! Not good.
This commit is contained in:
@@ -61,8 +61,12 @@ node.http.parseUri = function (str) {
|
||||
uri[o.q.name] = {};
|
||||
uri[o.key[12]].replace(o.q.parser, function ($0, $1, $2) {
|
||||
if ($1) {
|
||||
var key = decode($1);
|
||||
var val = decode($2);
|
||||
try {
|
||||
var key = decode($1);
|
||||
var val = decode($2);
|
||||
} catch (e) {
|
||||
return;
|
||||
}
|
||||
uri[o.q.name][key] = val;
|
||||
}
|
||||
});
|
||||
|
||||
31
test/mjsunit/test-http-malformed-request.js
Normal file
31
test/mjsunit/test-http-malformed-request.js
Normal file
@@ -0,0 +1,31 @@
|
||||
include("mjsunit.js");
|
||||
|
||||
// Make sure no exceptions are thrown when receiving malformed HTTP
|
||||
// requests.
|
||||
port = 9999;
|
||||
|
||||
nrequests_completed = 0;
|
||||
nrequests_expected = 1;
|
||||
|
||||
var s = node.http.createServer(function (req, res) {
|
||||
puts("req: " + JSON.stringify(req.uri));
|
||||
|
||||
res.sendHeader(200, {"Content-Type": "text/plain"});
|
||||
res.sendBody("Hello World");
|
||||
res.finish();
|
||||
|
||||
if (++nrequests_completed == nrequests_expected) s.close();
|
||||
});
|
||||
s.listen(port);
|
||||
|
||||
var c = node.tcp.createConnection(port);
|
||||
c.addListener("connect", function () {
|
||||
c.send("GET /hello?foo=%99bar HTTP/1.1\r\n\r\n");
|
||||
c.close();
|
||||
});
|
||||
|
||||
// TODO add more!
|
||||
|
||||
process.addListener("exit", function () {
|
||||
assertEquals(nrequests_expected, nrequests_completed);
|
||||
});
|
||||
Reference in New Issue
Block a user