mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
http: explain the possibilty of refactor unused argument
PR-URL: https://github.com/nodejs/node/pull/37275 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
committed by
Daniele Belardi
parent
9fa1f68b55
commit
9d2125e3bf
@@ -155,6 +155,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
|
||||
// argument adaptor frame creation inside V8 in case that number of actual
|
||||
// arguments is different from expected arguments.
|
||||
// Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201
|
||||
// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9.
|
||||
// Refactoring `n` out might be possible when V8 is upgraded to that
|
||||
// version.
|
||||
// Ref: https://v8.dev/blog/v8-release-89
|
||||
IncomingMessage.prototype._read = function _read(n) {
|
||||
if (!this._consuming) {
|
||||
this._readableState.readingMore = false;
|
||||
|
||||
Reference in New Issue
Block a user