OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

querystring: remove name from stringify()

Browse Source 
QueryString.stringify() allowed a fourth argument that was used as a
conditional in the return value, but was undocumented, not used by core
and always was always false/undefiend. So the argument and conditional
have been removed.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Yorkie
2013-12-28 20:59:57 +08:00
committed by Trevor Norris
parent 96dffb1217
commit 8d3bc88bbe
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/querystring.js
View File

@@ -125,7 +125,7 @@ var stringifyPrimitive = function(v) {
};
QueryString.stringify = QueryString.encode = function(obj, sep, eq, name) {
QueryString.stringify = QueryString.encode = function(obj, sep, eq) {
sep = sep || '&';
eq = eq || '=';
if (util.isNull(obj)) {
@@ -145,10 +145,7 @@ QueryString.stringify = QueryString.encode = function(obj, sep, eq, name) {
}).join(sep);
}
if (!name) return '';
return QueryString.escape(stringifyPrimitive(name)) + eq +
QueryString.escape(stringifyPrimitive(obj));
return '';
};
// Parse a key=val string.

2
test/simple/test-querystring.js
View File

@@ -124,7 +124,7 @@ qsWeirdObjects.forEach(function(testCase) {
});
qsNoMungeTestCases.forEach(function(testCase) {
assert.deepEqual(testCase[0], qs.stringify(testCase[1], '&', '=', false));
assert.deepEqual(testCase[0], qs.stringify(testCase[1], '&', '='));
});
// test the nested qs-in-qs case