tools: fix GYP MSVS solution generator for Python 3

PR-URL: https://github.com/nodejs/node/pull/29897
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This commit is contained in:
Michaël Zasso
2019-10-09 10:59:13 +02:00
parent 6c205aba00
commit 8728f8660a

View File

@@ -7,6 +7,7 @@
import hashlib
import os
import random
from operator import attrgetter
import gyp.common
@@ -86,7 +87,7 @@ class MSVSFolder(MSVSSolutionEntry):
self.guid = guid
# Copy passed lists (or set to empty lists)
self.entries = sorted(list(entries or []))
self.entries = sorted(entries or [], key=attrgetter('path'))
self.items = list(items or [])
self.entry_type_guid = ENTRY_TYPE_GUIDS['folder']
@@ -230,7 +231,7 @@ class MSVSSolution(object):
if isinstance(e, MSVSFolder):
entries_to_check += e.entries
all_entries = sorted(all_entries)
all_entries = sorted(all_entries, key=attrgetter('path'))
# Open file and print header
f = writer(self.path)