OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

src: add self-assigment memcpy checks

Browse Source 
Fixes: https://github.com/nodejs/node/issues/56718
PR-URL: https://github.com/nodejs/node/pull/56986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Burkov Egor
2025-02-12 16:13:02 +03:00
committed by GitHub
parent 9ce1fffcdc
commit 85f5a6cc1e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/node_sockaddr-inl.h
View File

@@ -79,12 +79,16 @@ SocketAddress::SocketAddress(const SocketAddress& addr) {
}
SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
memcpy(&address_, addr, GetLength(addr));
if (reinterpret_cast<const sockaddr*>(&address_) != addr) {
memcpy(&address_, addr, GetLength(addr));
}
return *this;
}
SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
memcpy(&address_, &addr.address_, addr.length());
if (this != &addr) {
memcpy(&address_, &addr.address_, addr.length());
}
return *this;
}