mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
lib: add parent to ERR_UNKNOWN_FILE_EXTENSION
- default_resolve updated to pass parentURL into error - ERR_UNKNOWN_FILE_EXTENSION updated to include parentURL - test added to check for import message in error PR-URL: https://github.com/nodejs/node/pull/30728 Fixes: https://github.com/nodejs/node/issues/30721 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
committed by
Guy Bedford
parent
6669cd138e
commit
7ab21b2f57
@@ -1228,7 +1228,9 @@ E('ERR_UNHANDLED_ERROR',
|
||||
E('ERR_UNKNOWN_BUILTIN_MODULE', 'No such built-in module: %s', Error);
|
||||
E('ERR_UNKNOWN_CREDENTIAL', '%s identifier does not exist: %s', Error);
|
||||
E('ERR_UNKNOWN_ENCODING', 'Unknown encoding: %s', TypeError);
|
||||
E('ERR_UNKNOWN_FILE_EXTENSION', 'Unknown file extension: %s', TypeError);
|
||||
E('ERR_UNKNOWN_FILE_EXTENSION',
|
||||
'Unknown file extension "%s" for %s imported from %s',
|
||||
TypeError);
|
||||
E('ERR_UNKNOWN_MODULE_FORMAT', 'Unknown module format: %s', RangeError);
|
||||
E('ERR_UNKNOWN_SIGNAL', 'Unknown signal: %s', TypeError);
|
||||
|
||||
|
||||
@@ -116,7 +116,10 @@ function resolve(specifier, parentURL) {
|
||||
'ExperimentalWarning');
|
||||
format = legacyExtensionFormatMap[ext];
|
||||
} else {
|
||||
throw new ERR_UNKNOWN_FILE_EXTENSION(fileURLToPath(url));
|
||||
throw new ERR_UNKNOWN_FILE_EXTENSION(
|
||||
ext,
|
||||
fileURLToPath(url),
|
||||
fileURLToPath(parentURL));
|
||||
}
|
||||
}
|
||||
return { url: `${url}`, format };
|
||||
|
||||
@@ -6,8 +6,10 @@ const { spawnSync } = require('child_process');
|
||||
const fixture = fixtures.path('/es-modules/import-invalid-ext.mjs');
|
||||
const child = spawnSync(process.execPath, [fixture]);
|
||||
const errMsg = 'TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension';
|
||||
const importMsg = `imported from ${fixture}`;
|
||||
|
||||
assert.strictEqual(child.status, 1);
|
||||
assert.strictEqual(child.signal, null);
|
||||
assert.strictEqual(child.stdout.toString().trim(), '');
|
||||
assert(child.stderr.toString().includes(errMsg));
|
||||
assert(child.stderr.toString().includes(importMsg));
|
||||
|
||||
Reference in New Issue
Block a user