OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: swapped == and equal to === and strictEqual

Browse Source 
Line 21 used '==' for a Number comparison, changed to '===''.
Lines 36 and 46 used 'assert.equal', changed to 'assert.strictEqual'.
Lines 2, 3 and 4 require statements used var, changed to const.

PR-URL: https://github.com/nodejs/node/pull/8472
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Christopher Dunavan
2016-09-09 15:28:15 -07:00
committed by Rich Trott
parent bf0a274da3
commit 77e9679600
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/parallel/test-net-remote-address-port.js
View File

@@ -1,8 +1,8 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
var net = require('net');
const net = require('net');
var conns_closed = 0;
@@ -18,7 +18,7 @@ var server = net.createServer(common.mustCall(function(socket) {
assert.ok(socket.remotePort);
assert.notEqual(socket.remotePort, this.address().port);
socket.on('end', function() {
if (++conns_closed == 2) server.close();
if (++conns_closed === 2) server.close();
});
socket.on('close', function() {
assert.notEqual(-1, remoteAddrCandidates.indexOf(socket.remoteAddress));
@@ -33,7 +33,7 @@ server.listen(0, 'localhost', function() {
client.on('connect', function() {
assert.notEqual(-1, remoteAddrCandidates.indexOf(client.remoteAddress));
assert.notEqual(-1, remoteFamilyCandidates.indexOf(client.remoteFamily));
assert.equal(client.remotePort, server.address().port);
assert.strictEqual(client.remotePort, server.address().port);
client.end();
});
client.on('close', function() {
@@ -43,7 +43,7 @@ server.listen(0, 'localhost', function() {
client2.on('connect', function() {
assert.notEqual(-1, remoteAddrCandidates.indexOf(client2.remoteAddress));
assert.notEqual(-1, remoteFamilyCandidates.indexOf(client2.remoteFamily));
assert.equal(client2.remotePort, server.address().port);
assert.strictEqual(client2.remotePort, server.address().port);
client2.end();
});
client2.on('close', function() {