OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

doc: add notable-change to onboarding.md exercise

Browse Source 
Pull requests that add new Collaborators should be labeled
`notable-change`. Make a note of this in onboarding.md.

PR-URL: https://github.com/nodejs/node/pull/21040
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott
2018-05-30 14:23:32 +02:00
parent 923f6ac08f
commit 77d3f141cf
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/onboarding.md
View File

@@ -211,7 +211,7 @@ needs to be pointed out separately during the onboarding.
-1`
* Collaborators are in alphabetical order by GitHub username.
* Optionally, include your personal pronouns.
* Label your pull request with the `doc` subsystem label.
* Label your pull request with the `doc` and `notable-change` labels.
* Run CI on the PR. Because the PR does not affect any code, use the
`node-test-pull-request-lite` CI task. Alternatively, use the usual
`node-test-pull-request` CI task and cancel it after the linter and one other