mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
stream: fix readable stream as async iterator function
Since v19.2 it's not possible to use readableStreams as async iterators (confirmed bug). This patch fixes the problem by reading the Stream.Duplex property from 'streams/duplex' instead of 'streams/legacy' module Fixes: https://github.com/nodejs/node/issues/46141 PR-URL: https://github.com/nodejs/node/pull/46147 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
@@ -13,6 +13,8 @@ const {
|
||||
const { pipelineImpl: pl } = require('internal/streams/pipeline');
|
||||
const { finished } = require('internal/streams/end-of-stream');
|
||||
|
||||
require('stream');
|
||||
|
||||
function pipeline(...streams) {
|
||||
return new Promise((resolve, reject) => {
|
||||
let signal;
|
||||
|
||||
27
test/parallel/test-stream3-pipeline-async-iterator.js
Normal file
27
test/parallel/test-stream3-pipeline-async-iterator.js
Normal file
@@ -0,0 +1,27 @@
|
||||
/* eslint-disable node-core/require-common-first, require-yield */
|
||||
'use strict';
|
||||
const { pipeline } = require('node:stream/promises');
|
||||
{
|
||||
// Ensure that async iterators can act as readable and writable streams
|
||||
async function* myCustomReadable() {
|
||||
yield 'Hello';
|
||||
yield 'World';
|
||||
}
|
||||
|
||||
const messages = [];
|
||||
async function* myCustomWritable(stream) {
|
||||
for await (const chunk of stream) {
|
||||
messages.push(chunk);
|
||||
}
|
||||
}
|
||||
|
||||
(async () => {
|
||||
await pipeline(
|
||||
myCustomReadable,
|
||||
myCustomWritable,
|
||||
);
|
||||
// Importing here to avoid initializing streams
|
||||
require('assert').deepStrictEqual(messages, ['Hello', 'World']);
|
||||
})()
|
||||
.then(require('../common').mustCall());
|
||||
}
|
||||
Reference in New Issue
Block a user