OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: use process.hrtime.bigint instead of process.hrtime

Browse Source 
`process.hrtime` is legacy. So replace `process.hrtime` with
`process.hrtime.bigint` in test.

Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime

Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45877
Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This commit is contained in:
Deokjin Kim
2023-01-01 20:07:47 +09:00
committed by GitHub
parent 91b9a470b8
commit 4b9f94bd90
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/parallel/test-http2-session-timeout.js
View File

@@ -5,6 +5,8 @@ if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
const hrtime = process.hrtime.bigint;
const NS_PER_MS = 1_000_000n;
let requests = 0;
const mustNotCall = () => {
@@ -14,7 +16,7 @@ const mustNotCall = () => {
const server = http2.createServer();
// Disable server timeout until first request. We will set the timeout based on
// how long the first request takes.
server.timeout = 0;
server.timeout = 0n;
server.on('request', (req, res) => res.end());
server.on('timeout', mustNotCall);
@@ -24,7 +26,7 @@ server.listen(0, common.mustCall(() => {
const url = `http://localhost:${port}`;
const client = http2.connect(url);
let startTime = process.hrtime();
let startTime = hrtime();
makeReq();
function makeReq() {
@@ -40,17 +42,17 @@ server.listen(0, common.mustCall(() => {
requests += 1;
request.on('end', () => {
const diff = process.hrtime(startTime);
const milliseconds = (diff[0] * 1e3 + diff[1] / 1e6);
if (server.timeout === 0) {
const diff = hrtime() - startTime;
const milliseconds = diff / NS_PER_MS;
if (server.timeout === 0n) {
// Set the timeout now. First connection will take significantly longer
// than subsequent connections, so using the duration of the first
// connection as the timeout should be robust. Double it anyway for good
// measure.
server.timeout = milliseconds * 2;
startTime = process.hrtime();
server.timeout = milliseconds * 2n;
startTime = hrtime();
makeReq();
} else if (milliseconds < server.timeout * 2) {
} else if (milliseconds < server.timeout * 2n) {
makeReq();
} else {
server.removeListener('timeout', mustNotCall);