OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: use common.skipIfInspectorDisabled() to skip tests

Browse Source 
some test files manually check for `!process.features.inspector`
to see if the tests should be skipped, the changes here update
those checks to instead use the more appropriate
`common.skipIfInspectorDisabled()`

PR-URL: https://github.com/nodejs/node/pull/58675
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
This commit is contained in:
Dario Piotrowicz
2025-06-13 13:10:51 +01:00
committed by GitHub
parent e148b24f51
commit 431c04d0bd
5 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-source-map-enable.js
View File

@@ -1,7 +1,5 @@
'use strict';
if (!process.features.inspector) return;
const common = require('../common');
const assert = require('assert');
const { dirname } = require('path');
@@ -10,6 +8,8 @@ const path = require('path');
const { spawnSync } = require('child_process');
const { pathToFileURL } = require('url');
common.skipIfInspectorDisabled();
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

4
test/parallel/test-v8-coverage.js
View File

@@ -1,13 +1,13 @@
'use strict';
if (!process.features.inspector) return;
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');
const { spawnSync } = require('child_process');
common.skipIfInspectorDisabled();
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

6
test/parallel/test-v8-stop-coverage.js
View File

@@ -1,14 +1,14 @@
'use strict';
if (!process.features.inspector) return;
require('../common');
const common = require('../common');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const { spawnSync } = require('child_process');
common.skipIfInspectorDisabled();
tmpdir.refresh();
const intervals = 20;

6
test/parallel/test-v8-take-coverage-noop.js
View File

@@ -1,14 +1,14 @@
'use strict';
if (!process.features.inspector) return;
require('../common');
const common = require('../common');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const { spawnSync } = require('child_process');
common.skipIfInspectorDisabled();
tmpdir.refresh();
// v8.takeCoverage() should be a noop if NODE_V8_COVERAGE is not set.

6
test/parallel/test-v8-take-coverage.js
View File

@@ -1,14 +1,14 @@
'use strict';
if (!process.features.inspector) return;
require('../common');
const common = require('../common');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const fs = require('fs');
const { spawnSync } = require('child_process');
common.skipIfInspectorDisabled();
tmpdir.refresh();
const intervals = 40;
// Outputs coverage when v8.takeCoverage() is invoked.