OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test_runner: fix test runner watch mode when no positional arguments

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/49578
Fixes: https://github.com/nodejs/node/issues/49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Moshe Atlow
2023-09-14 14:46:18 +03:00
committed by GitHub
parent 22907ce366
commit 1a4ae462f8
2 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/node_options.cc
View File

@@ -173,7 +173,7 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors,
} else if (force_repl) {
errors->push_back("either --watch or --interactive "
"can be used, not both");
} else if (argv->size() < 1 || (*argv)[1].empty()) {
} else if (!test_runner && (argv->size() < 1 || (*argv)[1].empty())) {
errors->push_back("--watch requires specifying a file");
}

23
test/parallel/test-runner-watch-mode.mjs
View File

@@ -17,7 +17,7 @@ tmpdir.refresh();
const fixtureContent = {
'dependency.js': 'module.exports = {};',
'dependency.mjs': 'export const a = 1;',
'dependent.js': `
'test.js': `
const test = require('node:test');
require('./dependency.js');
import('./dependency.mjs');
@@ -29,12 +29,12 @@ const fixturePaths = Object.keys(fixtureContent)
Object.entries(fixtureContent)
.forEach(([file, content]) => writeFileSync(fixturePaths[file], content));
async function testWatch({ fileToUpdate }) {
async function testWatch({ fileToUpdate, file }) {
const ran1 = util.createDeferredPromise();
const ran2 = util.createDeferredPromise();
const child = spawn(process.execPath,
['--watch', '--test', '--no-warnings', fixturePaths['dependent.js']],
{ encoding: 'utf8', stdio: 'pipe' });
['--watch', '--test', file ? fixturePaths[file] : undefined].filter(Boolean),
{ encoding: 'utf8', stdio: 'pipe', cwd: tmpdir.path });
let stdout = '';
child.stdout.on('data', (data) => {
@@ -47,10 +47,7 @@ async function testWatch({ fileToUpdate }) {
await ran1.promise;
const content = fixtureContent[fileToUpdate];
const path = fixturePaths[fileToUpdate];
const interval = setInterval(() => {
console.log(`Updating ${path}`);
writeFileSync(path, content);
}, 50);
const interval = setInterval(() => writeFileSync(path, content), common.platformTimeout(1000));
await ran2.promise;
clearInterval(interval);
child.kill();
@@ -58,14 +55,18 @@ async function testWatch({ fileToUpdate }) {
describe('test runner watch mode', () => {
it('should run tests repeatedly', async () => {
await testWatch({ fileToUpdate: 'dependent.js' });
await testWatch({ file: 'test.js', fileToUpdate: 'test.js' });
});
it('should run tests with dependency repeatedly', async () => {
await testWatch({ fileToUpdate: 'dependency.js' });
await testWatch({ file: 'test.js', fileToUpdate: 'dependency.js' });
});
it('should run tests with ESM dependency', async () => {
await testWatch({ fileToUpdate: 'dependency.mjs' });
await testWatch({ file: 'test.js', fileToUpdate: 'dependency.mjs' });
});
it('should support running tests without a file', async () => {
await testWatch({ fileToUpdate: 'test.js' });
});
});