OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

src: improve error handling in node_env_var.cc

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit is contained in:
Antoine du Hamel
2025-04-08 00:37:25 +02:00
committed by GitHub
parent b2ab1a2c41
commit 1540fc6a37
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/node_env_var.cc
View File

@@ -436,15 +436,14 @@ static Intercepted EnvGetter(Local<Name> property,
MaybeLocal<String> value_string =
env->env_vars()->Get(env->isolate(), property.As<String>());
bool has_env = !value_string.IsEmpty();
TraceEnvVar(env, "get", property.As<String>());
if (has_env) {
// ToLocalChecked here is ok since we check IsEmpty above.
info.GetReturnValue().Set(value_string.ToLocalChecked());
return Intercepted::kYes;
Local<Value> ret;
if (!value_string.ToLocal(&ret)) {
return Intercepted::kNo;
}
return Intercepted::kNo;
info.GetReturnValue().Set(ret);
return Intercepted::kYes;
}
static Intercepted EnvSetter(Local<Name> property,