mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
test: move test-shadow-realm-gc.js to known_issues
There is actually a leak. The test doesn't exercise the right path to create a substantial enough object graph (e.g. accessing something that results in the loading of a binding). This does something more complicated in the test and moves it to known_issues until we find a fix. PR-URL: https://github.com/nodejs/node/pull/47355 Refs: https://github.com/nodejs/node/issues/47353 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
@@ -11,6 +11,9 @@ prefix known_issues
|
||||
# foreseeable future. The test itself is flaky and skipped. It
|
||||
# serves as a demonstration of the issue only.
|
||||
test-vm-timeout-escape-queuemicrotask: SKIP
|
||||
# Skipping it because it crashes out of OOM instead of exiting.
|
||||
# https://github.com/nodejs/node/issues/47353
|
||||
test-shadow-realm-gc: SKIP
|
||||
|
||||
[$system==win32]
|
||||
|
||||
|
||||
@@ -8,5 +8,6 @@
|
||||
require('../common');
|
||||
|
||||
for (let i = 0; i < 1000; i++) {
|
||||
new ShadowRealm();
|
||||
const realm = new ShadowRealm();
|
||||
realm.evaluate('new TextEncoder(); 1;');
|
||||
}
|
||||
Reference in New Issue
Block a user