OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test_runner: remove plan option from run()

Browse Source 
This commit removes the plan option to run(). I believe it was
added by mistake. It is not documented, untested, and a test
plan does not make sense in the context of run().

This commit also fixes a minor formatting issue in a related
fixture.

Refs: https://github.com/nodejs/node/pull/52860
PR-URL: https://github.com/nodejs/node/pull/53834
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This commit is contained in:
Colin Ihrig
2024-07-15 13:10:01 -04:00
committed by GitHub
parent 6ba0af1354
commit 034a2409bf
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/internal/test_runner/runner.js
View File

@@ -483,7 +483,6 @@ function run(options = kEmptyObject) {
watch,
setup,
only,
plan,
} = options;
if (files != null) {
@@ -552,7 +551,7 @@ function run(options = kEmptyObject) {
});
}
const root = createTestTree({ __proto__: null, concurrency, timeout, signal, plan });
const root = createTestTree({ __proto__: null, concurrency, timeout, signal });
root.harness.shouldColorizeTestFiles ||= shouldColorizeTestFiles(root);
if (process.env.NODE_TEST_CONTEXT !== undefined) {

2
test/fixtures/test-runner/output/test-runner-plan.js vendored
View File

@@ -74,6 +74,6 @@ test('planning with streams', (t, done) => {
});
stream.on('end', () => {
done();
done();
});
})