mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
tools: add linter for release commit proposals
PR-URL: https://github.com/nodejs/node/pull/55923 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This commit is contained in:
59
.github/workflows/lint-release-proposal.yml
vendored
Normal file
59
.github/workflows/lint-release-proposal.yml
vendored
Normal file
@@ -0,0 +1,59 @@
|
||||
name: Linters (release proposals)
|
||||
|
||||
on:
|
||||
push:
|
||||
branches:
|
||||
- v[0-9]+.[0-9]+.[0-9]+-proposal
|
||||
|
||||
concurrency:
|
||||
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
|
||||
cancel-in-progress: true
|
||||
|
||||
env:
|
||||
PYTHON_VERSION: '3.12'
|
||||
NODE_VERSION: lts/*
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
|
||||
jobs:
|
||||
lint-release-commit:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
||||
with:
|
||||
persist-credentials: false
|
||||
- name: Lint release commit title format
|
||||
run: |
|
||||
EXPECTED_TITLE='^[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2}, Version [[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+ (\(Current|'.+' \(LTS)\)$'
|
||||
echo "Expected commit title format: $EXPECTED_TITLE"
|
||||
COMMIT_SUBJECT="$(git --no-pager log -1 --format=%s)"
|
||||
echo "Actual: $ACTUAL"
|
||||
echo "$COMMIT_SUBJECT" | grep -q -E "$EXPECTED_TITLE"
|
||||
echo "COMMIT_SUBJECT=$COMMIT_SUBJECT" >> "$GITHUB_ENV"
|
||||
- name: Lint release commit message trailers
|
||||
run: |
|
||||
EXPECTED_TRAILER="^PR-URL: $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/pull/[[:digit:]]+\$"
|
||||
echo "Expected trailer format: $EXPECTED_TRAILER"
|
||||
ACTUAL="$(git --no-pager log -1 --format=%b | git interpret-trailers --parse --no-divider)"
|
||||
echo "Actual: $ACTUAL"
|
||||
echo "$ACTUAL" | grep -E -q "$EXPECTED_TRAILER"
|
||||
|
||||
PR_URL="${ACTUAL:8}"
|
||||
PR_HEAD="$(gh pr view "$PR_URL" --json headRefOid -q .headRefOid)"
|
||||
echo "Head of $PR_URL: $PR_HEAD"
|
||||
echo "Current commit: $GITHUB_SHA"
|
||||
[[ "$PR_HEAD" == "$GITHUB_SHA" ]]
|
||||
env:
|
||||
GH_TOKEN: ${{ github.token }}
|
||||
- name: Validate CHANGELOG
|
||||
id: releaser-info
|
||||
run: |
|
||||
EXPECTED_CHANGELOG_TITLE_INTRO="## $COMMIT_SUBJECT, @"
|
||||
echo "Expected CHANGELOG section title: $EXPECTED_CHANGELOG_TITLE_INTRO"
|
||||
CHANGELOG_TITLE="$(grep "$EXPECTED_CHANGELOG_TITLE_INTRO" "doc/changelogs/CHANGELOG_V${COMMIT_SUBJECT:20:2}.md")"
|
||||
echo "Actual: $CHANGELOG_TITLE"
|
||||
[[ "${CHANGELOG_TITLE%@*}@" == "$EXPECTED_CHANGELOG_TITLE_INTRO" ]]
|
||||
- name: Verify NODE_VERSION_IS_RELEASE bit is correctly set
|
||||
run: |
|
||||
grep -q '^#define NODE_VERSION_IS_RELEASE 1$' src/node_version.h
|
||||
Reference in New Issue
Block a user