mirror of
https://github.com/zebrajr/node.git
synced 2026-01-15 12:15:26 +00:00
doc,src,test: assign missing deprecation code
PR-URL: https://github.com/nodejs/node/pull/31674 Refs: https://github.com/nodejs/node/pull/28396 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
@@ -2583,8 +2583,8 @@ accordingly instead to avoid the ambigiuty.
|
||||
To maintain existing behaviour `response.finished` should be replaced with
|
||||
`response.writableEnded`.
|
||||
|
||||
<a id="DEP00XX"></a>
|
||||
### DEP00XX: Closing fs.FileHandle on garbage collection
|
||||
<a id="DEP0137"></a>
|
||||
### DEP0137: Closing fs.FileHandle on garbage collection
|
||||
<!-- YAML
|
||||
changes:
|
||||
- version: REPLACEME
|
||||
|
||||
@@ -218,7 +218,7 @@ inline void FileHandle::Close() {
|
||||
"Please close FileHandle objects explicitly using "
|
||||
"FileHandle.prototype.close(). In the future, an error will be "
|
||||
"thrown if a file descriptor is closed during garbage collection.",
|
||||
"DEP00XX").IsNothing();
|
||||
"DEP0137").IsNothing();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
@@ -32,7 +32,7 @@ common.expectWarning({
|
||||
'Warning': [
|
||||
`Closing file descriptor ${fdnum} on garbage collection`
|
||||
],
|
||||
'DeprecationWarning': [[deprecationWarning, 'DEP00XX']]
|
||||
'DeprecationWarning': [[deprecationWarning, 'DEP0137']]
|
||||
});
|
||||
|
||||
global.gc();
|
||||
|
||||
@@ -21,7 +21,7 @@ async function doOpen() {
|
||||
|
||||
common.expectWarning({
|
||||
Warning: [[`Closing file descriptor ${fh.fd} on garbage collection`]],
|
||||
DeprecationWarning: [[warning, 'DEP00XX']]
|
||||
DeprecationWarning: [[warning, 'DEP0137']]
|
||||
});
|
||||
|
||||
return fh;
|
||||
|
||||
Reference in New Issue
Block a user