OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

tools: fix bug in prefer-primordials lint rule

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/46659
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Antoine du Hamel
2023-02-17 19:29:42 +01:00
committed by GitHub
parent 18651ad7a0
commit 0084fc7994
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/parallel/test-eslint-prefer-primordials.js
View File

@@ -57,7 +57,9 @@ new RuleTester({
{
code: `
const { ObjectDefineProperty, Symbol } = primordials;
ObjectDefineProperty(o, Symbol.toStringTag, { value: "o" })
ObjectDefineProperty(o, Symbol.toStringTag, { value: "o" });
const val = Symbol.toStringTag;
const { toStringTag } = Symbol;
`,
options: [{ name: 'Symbol', ignore: ['toStringTag'] }]
},

2
tools/eslint-rules/prefer-primordials.js
View File

@@ -114,7 +114,7 @@ module.exports = {
node,
);
const parentName = parent?.name;
if (!isTarget(nameMap, name) && !isTarget(nameMap, parentName)) {
if (!isTarget(nameMap, name) && (!isTarget(nameMap, parentName) || isIgnored(nameMap, parentName, name))) {
return;
}