mirror of
https://github.com/zebrajr/ladybird.git
synced 2026-01-15 12:15:15 +00:00
fb2d9e3c85
For some reason, writing to the wake fd from the same thread in
deferred_invoke was causing a deadlock. However, we don't actually need
to wake from the same thread, since the event loop is not waiting and
will therefore process the deferred_invoke on the next iteration.
This issue was introduced in 3742138cc3.
The deadlock could be reproduced consistently by increasing
LOCAL_STORAGE_QUOTA in StorageJar.cpp to a large value like 50 MiB.
52 lines
1.3 KiB
C++
52 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) 2023, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/NonnullOwnPtr.h>
|
|
#include <LibCore/Event.h>
|
|
#include <LibCore/EventLoopImplementation.h>
|
|
#include <LibCore/ThreadEventQueue.h>
|
|
#ifdef AK_OS_WINDOWS
|
|
# include <LibCore/EventLoopImplementationWindows.h>
|
|
#else
|
|
# include <LibCore/EventLoopImplementationUnix.h>
|
|
#endif
|
|
|
|
namespace Core {
|
|
|
|
EventLoopImplementation::EventLoopImplementation()
|
|
: m_thread_event_queue(ThreadEventQueue::current())
|
|
{
|
|
}
|
|
|
|
EventLoopImplementation::~EventLoopImplementation() = default;
|
|
|
|
void EventLoopImplementation::deferred_invoke(Function<void()>&& invokee)
|
|
{
|
|
m_thread_event_queue.deferred_invoke(move(invokee));
|
|
if (&m_thread_event_queue != ThreadEventQueue::current_or_null())
|
|
wake();
|
|
}
|
|
|
|
static EventLoopManager* s_event_loop_manager = nullptr;
|
|
EventLoopManager& EventLoopManager::the()
|
|
{
|
|
if (!s_event_loop_manager)
|
|
s_event_loop_manager = new EventLoopManagerPlatform;
|
|
return *s_event_loop_manager;
|
|
}
|
|
|
|
void EventLoopManager::install(Core::EventLoopManager& manager)
|
|
{
|
|
VERIFY(!s_event_loop_manager);
|
|
s_event_loop_manager = &manager;
|
|
}
|
|
|
|
EventLoopManager::EventLoopManager() = default;
|
|
|
|
EventLoopManager::~EventLoopManager() = default;
|
|
|
|
}
|