mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00

Files

Sebastian Markbåge f9dddcbbb1 [Fizz] Fix Client Render after Postpone (#27905 )

If we end up client rendering a boundary due to an error after we have
already injected a postponed hole in that boundary we'll end up trying
to target a missing segment. Since we never insert segments for an
already errored boundary into the HTML. Normally an errored prerender
wouldn't be used but if it is, such as if it was an intentional client
error it triggers this case. Those should really be replaced with
postpones though.

This is a bit annoying since we eagerly build up the postponed path. I
took the easy route here and just cleared out the suspense boundary
itself from having any postponed slots. However, this still creates an
unnecessary replay path along the way to the boundary. We could probably
walk the path and remove any empty parent nodes.

What is worse is that if this is the only thing that postponed, we'd
still generate a postponed state even though there's actually nothing to
resume. Since this is a bit of an edge case already maybe it's fine.

In my test I added a check for the `error` event on `window` since this
error only surfaces by throwing an ignored error. We should really do
that globally for all tests. Our tests should fail by default if there's
an error logged to the window.

2024-01-08 23:52:33 -05:00

npm

Remove Blocks (#20138 )

2020-10-30 23:03:45 -07:00

src

[Fizz] Fix Client Render after Postpone (#27905 )

2024-01-08 23:52:33 -05:00

flight.js

[Codemod] Update copyright header to Meta (#25315 )

2022-10-18 11:19:24 -04:00

index.js

[Codemod] Update copyright header to Meta (#25315 )