mirror of
https://github.com/zebrajr/react.git
synced 2026-01-15 12:15:22 +00:00
9043ad6b9d
* Add a regression test that passes in Stack but fails in Fiber The failure happens because trackValueOnNode() can exit early if it detects an existing descriptor on node, or if it sees a "broken" Safari descriptor (which is how we encountered this bug in the wild). As a result, the tracker field was not set, and subsequent updateValueIfChanged() call went into the branch that initializes the tracker lazily. That branch has a bug in Fiber mode where it passes the wrong type. We did not see this issue before because that branch is relatively hard to hit (you have to either run it in Safari or define a custom DOM value descriptor which is what I did in the test). In the future, we will likely remove the lazy branch altogether since if we bailed out of setting up the tracker once, we will likely bail out every time. But for now I'm just focused on a minimal fix to unbreak master. * Fix updateValueIfChanged() lazy path to work with DOM argument * Slightly reorder lines for clarity and record tests * Also test the change event code path This makes it go through the Fiber argument code path.