mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00

Files

Sebastian Markbåge 3cfcdfb307 [Flight] Resolve Deep Cycles (#33664 )

Stacked on #33666.

If we ever get a future reference to a cycle and that reference gets
eagerly parsed before the target has loaded then we can end up with a
cycle that never gets resolved. That's because our cycle resolution only
works if the cyclic future reference is created synchronously within the
parsing path of the child.

I haven't been able to construct a normal scenario where this would
break. So this doesn't fail any tests. However, I can construct it with
debug info since those are eagerly evaluated. It's also a prerequisite
if the debug data can come out of order, like if it's on a different
stream.

The fix here is to make all the internal dependencies in the "listener"
list into introspectable objects instead of closures. That way we can
traverse the list of dependencies of a blocked reference to see if it
ends up in a cycle and therefore skip the reference.

It would be nice to address this once and for all to be more resilient
to server changes, but I'm not sure if it's worth this complexity and
the extra CPU cost of tracing the dependencies. Especially if it's just
for debug data.

closes #32316
fixes vercel/next.js#72104

---------

Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>

2025-06-29 10:56:16 -04:00

npm

Don't minify symbols in production builds (#28881 )

2024-04-20 11:23:46 -04:00

src

[Flight] Resolve Deep Cycles (#33664 )

2025-06-29 10:56:16 -04:00

flight.js

Remove Flight Relay DOM/Native (#26828 )

2023-05-17 20:33:25 -04:00

package.json

Remove loose-envify dep and browserify configs (#28480 )