react

mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00

Files

Ruslan Lesiutin 1d8d12005f fix[react-devtools]: remove all listeners when Agent is shutdown (#31151 )

Based on https://github.com/facebook/react/pull/31049, credits to
@EdmondChuiHW.

What is happening here:
1. Once Agent is destroyed, unsubscribe own listeners and bridge
listeners.
2. [Browser extension only] Once Agent is destroyed, unsubscribe
listeners from BackendManager.
3. [Browser extension only] I've discovered that `backendManager.js`
content script can get injected multiple times by the browser. When
Frontend is initializing, it will create Store first, and then execute a
content script for bootstraping backend manager. If Frontend was
destroyed somewhere between these 2 steps, Backend won't be notified,
because it is not initialized yet, so it will not unsubscribe listeners
correctly. We might end up duplicating listeners, and the next time
Frontend is launched, it will report an issues "Cannot add / remove node
...", because same operations are emitted twice.

To reproduce 3 you can do the following:
1. Click reload-to-profile
2. Right after when both app and Chrome DevTools panel are reloaded,
close Chrome DevTools.
3. Open Chrome DevTools again, open Profiler panel and observe "Cannot
add / remove node ..." error in the UI.

2024-10-09 13:34:01 +01:00

src

fix[react-devtools]: remove all listeners when Agent is shutdown (#31151 )

2024-10-09 13:34:01 +01:00

babel.config.js

feat[react-devtools]: support Manifest v3 for Firefox extension (#30824 )

2024-08-29 11:28:35 +01:00

buildUtils.js

feat[devtools]: add package for fusebox integration (#28553 )

2024-04-12 15:29:35 +01:00

package.json

[DevTools] Remove lodash.throttle (#30657 )