From a09950ed418adb26a5e735b4ee9eca5e5282ffc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Thu, 11 Jul 2024 13:05:26 -0400 Subject: [PATCH] Gate inlined consoleWithStackDev transpilation (#30317) This code is getting deleted in #30313 anyway but it should've been gated all along. This code exists to basically manually transpile console.error to consoleWithStackDev because the transpiler doesn't work on `.apply` or `.bind` or the dynamic look up. We only apply the transform in DEV so we should've only done this in DEV. Otherwise these logs get silenced in prod. --- packages/react-client/src/ReactClientConsoleConfigBrowser.js | 4 ++-- packages/react-client/src/ReactClientConsoleConfigPlain.js | 4 ++-- packages/react-client/src/ReactClientConsoleConfigServer.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-client/src/ReactClientConsoleConfigBrowser.js b/packages/react-client/src/ReactClientConsoleConfigBrowser.js index a8a375debd..a80a410d28 100644 --- a/packages/react-client/src/ReactClientConsoleConfigBrowser.js +++ b/packages/react-client/src/ReactClientConsoleConfigBrowser.js @@ -65,9 +65,9 @@ export function printToConsole( ); } - if (methodName === 'error') { + if (methodName === 'error' && __DEV__) { error.apply(console, newArgs); - } else if (methodName === 'warn') { + } else if (methodName === 'warn' && __DEV__) { warn.apply(console, newArgs); } else { // $FlowFixMe[invalid-computed-prop] diff --git a/packages/react-client/src/ReactClientConsoleConfigPlain.js b/packages/react-client/src/ReactClientConsoleConfigPlain.js index 64b61d6ed6..45069ea7bd 100644 --- a/packages/react-client/src/ReactClientConsoleConfigPlain.js +++ b/packages/react-client/src/ReactClientConsoleConfigPlain.js @@ -46,9 +46,9 @@ export function printToConsole( newArgs.splice(offset, 0, badgeFormat, pad + badgeName + pad); } - if (methodName === 'error') { + if (methodName === 'error' && __DEV__) { error.apply(console, newArgs); - } else if (methodName === 'warn') { + } else if (methodName === 'warn' && __DEV__) { warn.apply(console, newArgs); } else { // $FlowFixMe[invalid-computed-prop] diff --git a/packages/react-client/src/ReactClientConsoleConfigServer.js b/packages/react-client/src/ReactClientConsoleConfigServer.js index 0a62707cf6..8ae8152a08 100644 --- a/packages/react-client/src/ReactClientConsoleConfigServer.js +++ b/packages/react-client/src/ReactClientConsoleConfigServer.js @@ -66,9 +66,9 @@ export function printToConsole( ); } - if (methodName === 'error') { + if (methodName === 'error' && __DEV__) { error.apply(console, newArgs); - } else if (methodName === 'warn') { + } else if (methodName === 'warn' && __DEV__) { warn.apply(console, newArgs); } else { // $FlowFixMe[invalid-computed-prop]