From 4880eb0fbce306aabce4ece12eb5a246fb25097f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kiho=20=C2=B7=20Cham?= Date: Sun, 2 Jul 2017 20:24:45 +0800 Subject: [PATCH] doc: switch the order of lint and prettier (#10094) Ref #9876 Thanks to @wdhorton bring it up. --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5de9012e12..58887ff353 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,8 +4,8 @@ 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure the test suite passes (`npm test`). -5. Make sure your code lints (`npm run lint`). -6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`). +5. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`). +6. Make sure your code lints (`npm run lint`). 7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`). 8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes. 9. If you haven't already, complete the CLA.