diff --git a/src/utils/Transaction.js b/src/utils/Transaction.js index 5029d213e4..ede94e0f2e 100644 --- a/src/utils/Transaction.js +++ b/src/utils/Transaction.js @@ -57,9 +57,6 @@ var invariant = require('invariant'); * +-----------------------------------------+ * * - * Bonus: - * - Reports timing metrics by method name and wrapper index. - * * Use cases: * - Preserving the input selection ranges before/after reconciliation. * Restoring selection even in the event of an unexpected error. @@ -99,20 +96,6 @@ var Mixin = { } else { this.wrapperInitData.length = 0; } - if (!this.timingMetrics) { - this.timingMetrics = {}; - } - this.timingMetrics.methodInvocationTime = 0; - if (!this.timingMetrics.wrapperInitTimes) { - this.timingMetrics.wrapperInitTimes = []; - } else { - this.timingMetrics.wrapperInitTimes.length = 0; - } - if (!this.timingMetrics.wrapperCloseTimes) { - this.timingMetrics.wrapperCloseTimes = []; - } else { - this.timingMetrics.wrapperCloseTimes.length = 0; - } this._isInTransaction = false; }, @@ -145,7 +128,6 @@ var Mixin = { 'Transaction.perform(...): Cannot initialize a transaction when there ' + 'is already an outstanding transaction.' ); - var memberStart = Date.now(); var errorThrown; var ret; try { @@ -159,8 +141,6 @@ var Mixin = { ret = method.call(scope, a, b, c, d, e, f); errorThrown = false; } finally { - var memberEnd = Date.now(); - this.methodInvocationTime += (memberEnd - memberStart); try { if (errorThrown) { // If `method` throws, prefer to show that stack trace over any thrown @@ -183,9 +163,7 @@ var Mixin = { initializeAll: function(startIndex) { var transactionWrappers = this.transactionWrappers; - var wrapperInitTimes = this.timingMetrics.wrapperInitTimes; for (var i = startIndex; i < transactionWrappers.length; i++) { - var initStart = Date.now(); var wrapper = transactionWrappers[i]; try { // Catching errors makes debugging more difficult, so we start with the @@ -197,10 +175,6 @@ var Mixin = { wrapper.initialize.call(this) : null; } finally { - var curInitTime = wrapperInitTimes[i]; - var initEnd = Date.now(); - wrapperInitTimes[i] = (curInitTime || 0) + (initEnd - initStart); - if (this.wrapperInitData[i] === Transaction.OBSERVED_ERROR) { // The initializer for wrapper i threw an error; initialize the // remaining wrappers but silence any exceptions from them to ensure @@ -226,10 +200,8 @@ var Mixin = { 'Transaction.closeAll(): Cannot close transaction when none are open.' ); var transactionWrappers = this.transactionWrappers; - var wrapperCloseTimes = this.timingMetrics.wrapperCloseTimes; for (var i = startIndex; i < transactionWrappers.length; i++) { var wrapper = transactionWrappers[i]; - var closeStart = Date.now(); var initData = this.wrapperInitData[i]; var errorThrown; try { @@ -243,10 +215,6 @@ var Mixin = { } errorThrown = false; } finally { - var closeEnd = Date.now(); - var curCloseTime = wrapperCloseTimes[i]; - wrapperCloseTimes[i] = (curCloseTime || 0) + (closeEnd - closeStart); - if (errorThrown) { // The closer for wrapper i threw an error; close the remaining // wrappers but silence any exceptions from them to ensure that the