Port more tests to the Scheduler.unstable_yieldValue pattern and drop internal.js (#18549)

Browse Source

* Drop the .internal.js suffix on some files that don't need it anymore

* Port some ops patterns to scheduler yield

* Fix triangle test to avoid side-effects in constructor

* Move replaying of setState updaters until after the effect

Otherwise any warnings get silenced if they're deduped.

* Drop .internal.js in more files

* Don't check propTypes on a simple memo component unless it's lazy

Comparing the elementType doesn't work for this because it will never be
the same for a simple element.

This caused us to double validate these. This was covered up because in
internal tests this was deduped since they shared the prop types cache
but since we now inline it, it doesn't get deduped.

...

This commit is contained in:

Sebastian Markbåge

2020-04-08 20:54:54 -07:00

committed by GitHub

parent b014e2d5e3

commit 147bdef11b

21 changed files with 494 additions and 715 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

0

packages/use-subscription/src/__tests__/useSubscription-test.internal.js → packages/use-subscription/src/__tests__/useSubscription-test.js