From 113c8e7f72bcf5d3bc285546da1508b45da3cf53 Mon Sep 17 00:00:00 2001
From: Lauren Tan <poteto@users.noreply.github.com>
Date: Fri, 31 May 2024 09:18:26 +0900
Subject: [PATCH] [compiler:eslint] Don't crash if hermes parser fails to parse

Eslint rules should never throw, so if we fail to parse with Babel or
Hermes, we should just ignore the error. This should fix issues such as
trying to run the eslint rule on non tsx|ts|jsx|js files, Hermes parser
not supporting certain JS syntax, etc.

I didn't add a test for this as our eslint-rule-tester config uses
hermes-eslint parser, so it wasn't possible to add a top level await as
it would crash hermes-eslint before our rule was triggered. Similarly I
couldn't add a test for non-JS files as it would not be parseable by
hermes-eslint.

Fixes #29107

ghstack-source-id: 60afcdb89ab4a8d2e4697cc50c5490803e7cbeac
Pull Request resolved: https://github.com/facebook/react/pull/29631
---
 .../src/rules/ReactCompilerRule.ts                 | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts b/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts
index fd33ae0339..7c46cf0b88 100644
--- a/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts
+++ b/compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts
@@ -124,12 +124,14 @@ const rule: Rule.RuleModule = {
         });
       } catch {}
     } else {
-      babelAST = HermesParser.parse(sourceCode, {
-        babel: true,
-        enableExperimentalComponentSyntax: true,
-        sourceFilename: filename,
-        sourceType: "module",
-      });
+      try {
+        babelAST = HermesParser.parse(sourceCode, {
+          babel: true,
+          enableExperimentalComponentSyntax: true,
+          sourceFilename: filename,
+          sourceType: "module",
+        });
+      } catch {}
     }
 
     if (babelAST != null) {