Trivikram 2bdf3ca235 http2: callback valid check before closing request ...

Do not close the request if callback is not a function, and
throw ERR_INVALID_CALLBACK TypeError

Backport-PR-URL: https://github.com/nodejs/node/pull/19229
PR-URL: https://github.com/nodejs/node/pull/19061
Fixes: https://github.com/nodejs/node/issues/18855
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

2018-04-04 16:40:56 +02:00

..

internal

http2: callback valid check before closing request

2018-04-04 16:40:56 +02:00

_http_agent.js

http: allow _httpMessage to be GC'ed

2018-02-26 23:42:45 +01:00

_http_client.js

http: fix request when setHost is true

2018-04-04 12:04:55 +02:00

_http_common.js

http: simplify checkInvalidHeaderChar

2018-02-21 14:20:31 -05:00

_http_incoming.js

…

_http_outgoing.js

http: switch on string values

2018-02-21 10:18:44 -05:00

_http_server.js

src: refactor stream callbacks and ownership

2018-02-26 18:39:41 -05:00

_stream_duplex.js

stream: make Duplex inherits from DuplexBase

2018-03-20 11:33:42 +00:00

_stream_passthrough.js

…

_stream_readable.js

stream: improve stream creation performance

2018-03-27 15:53:05 +02:00

_stream_transform.js

stream: delete unused code

2018-02-21 10:19:09 -05:00

_stream_wrap.js

…

_stream_writable.js

stream: improve stream creation performance

2018-03-27 15:53:05 +02:00

_tls_common.js

tls: implement clientCertEngine option

2017-12-11 15:39:08 -05:00

_tls_legacy.js

tls: comment about old-style errors

2018-01-09 04:32:28 -05:00

_tls_wrap.js

crypto: provide full cert details to checkServerIdentity

2018-03-24 20:27:09 +01:00

.eslintrc.yaml

lib: add internal check macros

2018-04-02 14:20:48 +02:00

assert.js

assert: fix throws trace

2018-03-20 11:33:38 +00:00

async_hooks.js

async_hooks: don't set hook_fields[kTotals] to 0

2018-03-20 11:33:57 +00:00

buffer.js

buffer: remove "new" from deprecation message

2018-04-02 16:09:29 +02:00

child_process.js

util: implement util.getSystemErrorName()

2018-02-26 18:39:48 -05:00

cluster.js

…

console.js

console: don't swallow call stack exceeded errors

2018-03-27 16:07:53 +02:00

constants.js

…

crypto.js

crypto: migrate setFipsCrypto to internal/errors

2017-10-27 08:13:01 -07:00

dgram.js

errors: move error creation helpers to errors.js

2018-02-26 18:39:49 -05:00

dns.js

errors: move error creation helpers to errors.js

2018-02-26 18:39:49 -05:00

domain.js

src: put bootstrappers in lib/internal/bootstrap/

2018-04-04 16:21:09 +02:00

events.js

events: show throw stack trace for uncaught exception

2018-03-05 10:07:17 +00:00

fs.js

fs: use fs.access in fs.exists

2018-04-04 16:14:33 +02:00

http2.js

…

http.js

http: support server options on createServer

2018-03-30 17:22:40 +02:00

https.js

https: add extra options to Agent#getName()

2018-02-21 14:20:07 -05:00

inspector.js

lib: enable dot-notation eslint rule

2018-01-10 01:42:28 -05:00

module.js

lib: add back lib/module.js redirection

2018-04-04 16:21:25 +02:00

net.js

fs,net: emit 'ready' for fs streams and sockets

2018-03-30 17:21:17 +02:00

os.js

…

path.js

path: fix regression in posix.normalize

2018-03-24 17:53:36 +01:00

perf_hooks.js

perf_hooks: fix timing

2018-03-07 09:30:20 -08:00

process.js

…

punycode.js

…

querystring.js

querystring: convert to using internal/errors

2017-10-28 14:04:53 -04:00

readline.js

lib: switch to Number.isNaN

2018-02-21 14:20:28 -05:00

repl.js

lib: restructure cjs and esm loaders

2018-04-04 16:21:19 +02:00

stream.js

tools: non-Ascii linter for /lib only

2018-02-21 10:19:15 -05:00

string_decoder.js

string_decoder: reset decoder on end

2018-02-21 10:19:08 -05:00

sys.js

…

timers.js

lib: fix a typo in lib/timers "read through"

2018-04-02 15:26:34 +02:00

tls.js

doc: document tls.checkServerIdentity

2017-12-12 03:28:03 -05:00

tty.js

tty: refactor to es6

2018-03-20 11:33:37 +00:00

url.js

url: remove redundant function

2018-03-30 17:19:19 +02:00

util.js

util: add util.inspect compact option

2018-03-20 11:33:36 +00:00

v8.js

v8: migrate setFlagsFromString to internal/errors

2017-10-29 23:07:52 -07:00

vm.js

vm: consolidate validation

2018-02-26 23:42:43 +01:00

zlib.js

lib: switch to Number.isNaN

2018-02-21 14:20:28 -05:00