Philipp Dunkel ff566276da net: remove unreachable check in internalConnect ...

Checked all call-sites to ensure that this code is truly unreachable.
addressType is always checked before internalConnect is even called.

PR-URL: https://github.com/nodejs/node/pull/24158
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

2018-11-13 15:30:12 -08:00

..

internal

src: remove pushValueToArray and SetupProcessObject

2018-11-14 02:59:45 +08:00

_http_agent.js

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10 08:45:56 +02:00

_http_client.js

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10 08:45:56 +02:00

_http_common.js

http: reduce duplicated code for cleaning parser

2018-10-12 14:53:36 -07:00

_http_incoming.js

http: added aborted property to request

2018-04-26 19:38:27 +02:00

_http_outgoing.js

http: remove obsolete function escapeHeaderValue

2018-11-13 09:50:07 +05:30

_http_server.js

async_hooks: add missing async_hooks destroys in AsyncReset

2018-10-10 08:45:56 +02:00

_stream_duplex.js

stream: only check options once in Duplex ctor

2018-04-28 17:13:55 +02:00

_stream_passthrough.js

…

_stream_readable.js

stream: add auto-destroy mode

2018-10-30 15:17:40 +01:00

_stream_transform.js

stream: make virtual methods errors consistent

2018-03-12 14:24:34 +01:00

_stream_wrap.js

…

_stream_writable.js

stream: make .destroy() interact better with write queue

2018-11-10 21:54:48 +01:00

_tls_common.js

tls: remove unused arg to createSecureContext()

2018-11-09 18:28:07 -08:00

_tls_wrap.js

tls: deprecate Server.prototype.setOptions()

2018-10-25 15:34:53 -04:00

.eslintrc.yaml

bootstrapper: move internalBinding to NativeModule

2018-10-04 11:55:34 +02:00

assert.js

assert: remove unused catch bindings

2018-11-06 10:58:42 -05:00

async_hooks.js

lib: extract validateString validator

2018-08-07 10:51:27 -04:00

buffer.js

buffer: move process.binding('buffer') to internalBinding

2018-10-15 19:01:20 +08:00

child_process.js

Revert "child_process: change windowsHide default to true"

2018-11-13 14:38:23 -08:00

cluster.js

…

console.js

console: console.timeLog() using the default label

2018-11-13 10:02:56 +05:30

constants.js

src,lib: move natives and constants to internalBinding()

2018-10-21 03:17:12 +02:00

crypto.js

src: cache the result of GetOptions() in JS land

2018-11-07 20:40:38 -08:00

dgram.js

src,lib: move natives and constants to internalBinding()

2018-10-21 03:17:12 +02:00

dns.js

dns: fix inconsistent (hostname vs host)

2018-10-20 21:56:28 -07:00

domain.js

async_hooks: remove promise object from resource

2018-10-15 19:40:51 +01:00

events.js

events: remove unused catch bindings

2018-11-06 10:58:47 -05:00

fs.js

src: prefer param function check over args length

2018-11-07 19:42:06 -08:00

http2.js

http2: graduate from experimental

2018-08-24 18:37:35 -07:00

http.js

http: allow url and options to be passed to http*.request and http*.get

2018-07-13 14:09:39 +01:00

https.js

https: allow url and options to be passed to https.request

2018-07-31 22:53:25 -07:00

inspector.js

inspector: enable Inspector JS API in workers

2018-09-17 09:49:53 -07:00

module.js

lib: add back lib/module.js redirection

2018-03-15 20:50:35 +08:00

net.js

net: remove unreachable check in internalConnect

2018-11-13 15:30:12 -08:00

os.js

os: do not call into JS to push values to an array in GetCPUInfo

2018-11-14 02:59:45 +08:00

path.js

lib: remove useless cwd in posix.resolve

2018-10-30 05:23:52 +01:00

perf_hooks.js

bootstrapper: move internalBinding to NativeModule

2018-10-04 11:55:34 +02:00

process.js

…

punycode.js

lib: update punycode to 2.1.1

2018-07-16 15:55:15 -07:00

querystring.js

querystring: remove unused catch bindings

2018-11-06 10:59:09 -05:00

readline.js

lib: repl multiline history support

2018-11-02 13:56:33 -07:00

repl.js

src: cache the result of GetOptions() in JS land

2018-11-07 20:40:38 -08:00

stream.js

tools: lint for unused catch bindings

2018-11-06 10:59:27 -05:00

string_decoder.js

bootstrapper: move internalBinding to NativeModule

2018-10-04 11:55:34 +02:00

sys.js

…

timers.js

timers: run nextTicks after each immediate and timer

2018-10-17 20:38:07 -07:00

tls.js

tls: throw if protocol too long

2018-10-23 21:05:47 -07:00

trace_events.js

trace_events: forbid tracing modifications from worker threads

2018-10-24 11:20:35 -03:00

tty.js

Revert "tty: make _read throw ERR_TTY_WRITABLE_NOT_READABLE"

2018-10-04 09:20:21 -07:00

url.js

icu: make process.binding('icu') internal

2018-10-08 23:42:52 -04:00

util.js

util: treat format arguments equally

2018-10-17 19:56:43 +02:00

v8.js

buffer: move process.binding('buffer') to internalBinding

2018-10-15 19:01:20 +08:00

vm.js

src: cache the result of GetOptions() in JS land

2018-11-07 20:40:38 -08:00

worker_threads.js

worker: rename to worker_threads

2018-06-06 19:44:15 +02:00

zlib.js

zlib: do not leak on destroy

2018-10-23 17:59:17 +02:00