Anna Henningsen f81a69aefe fs: fix createReadStream(…, {end: n}) for non-seekable fds ...

82bdf8fba2 fixed an issue by silently modifying the `start`
option for the case when only `end` is passed, in order to perform
reads from a specified range in the file.

However, that approach does not work for non-seekable files, since
a numeric `start` option means that positioned reads will be used
to read data from the file.

This patch fixes that, and instead ends reading after a specified
size by adjusting the read buffer size.

This way we avoid re-introducing the bug that 82bdf8fba2 fixed,
and align behaviour with the native file stream mechanism
introduced in https://github.com/nodejs/node/pull/18936 as well.

Backport-PR-URL: https://github.com/nodejs/node/pull/19411
PR-URL: https://github.com/nodejs/node/pull/19329
Fixes: https://github.com/nodejs/node/issues/19240
Refs: https://github.com/nodejs/node/pull/18121
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chen Gang <gangc.cxy@foxmail.com>

2018-03-29 23:25:34 -04:00

..

internal

lib: enable dot-notation eslint rule

2018-02-27 00:01:59 -05:00

_debug_agent.js

lib: remove unused msg parameter in debug_agent

2017-04-18 20:02:10 -04:00

_debugger.js

lib: enable dot-notation eslint rule

2018-02-27 00:01:59 -05:00

_http_agent.js

http, tls: better support for IPv6 addresses

2018-02-26 21:37:27 -05:00

_http_client.js

https: support rejectUnauthorized for unix sockets

2017-07-30 23:11:12 -05:00

_http_common.js

http: fix connection upgrade checks

2016-09-09 11:06:06 -04:00

_http_incoming.js

http: fix no dumping after maybeReadMore

2016-06-15 21:50:05 -05:00

_http_outgoing.js

http: fix first body chunk fast case for UTF-16

2017-07-11 17:43:45 +01:00

_http_server.js

http: describe parse err in debug output

2017-07-30 23:11:12 -05:00

_linklist.js

lib,test: deprecate _linklist

2015-10-08 17:32:08 -07:00

_stream_duplex.js

node: allow multiple arguments passed to nextTick

2015-04-15 17:02:21 -06:00

_stream_passthrough.js

lib: use const to define constants

2015-01-21 16:21:31 -05:00

_stream_readable.js

tools: remove legacy indentation linting

2017-09-05 12:49:50 -04:00

_stream_transform.js

src: fixes misplaced comment

2016-10-11 12:30:40 -04:00

_stream_wrap.js

test,lib,benchmark: match function names

2016-11-15 13:31:46 -05:00

_stream_writable.js

stream: fix disparity between buffer and the count

2018-01-02 14:06:34 -05:00

_tls_common.js

tls: fix empty issuer/subject/infoAccess parsing

2017-09-19 14:22:39 -04:00

_tls_legacy.js

tls: comment about old-style errors

2018-02-12 19:28:23 -05:00

_tls_wrap.js

tls: accept lookup option for tls.connect()

2018-01-11 13:04:34 -05:00

.eslintrc.yaml

lib: enable dot-notation eslint rule

2018-02-27 00:01:59 -05:00

assert.js

assert: improve assert.fail() API

2017-10-25 04:09:42 -04:00

buffer.js

lib: remove excess indentation

2017-09-05 12:49:49 -04:00

child_process.js

child_process: set shell to false in fork()

2017-11-28 13:09:53 +09:00

cluster.js

cluster, dns, repl, tls, util: fix RegExp nits

2017-07-21 14:35:04 -04:00

console.js

console: add console.count() and console.clear()

2018-02-12 19:28:05 -05:00

constants.js

constants: errors -> errno

2016-12-20 14:42:45 -05:00

crypto.js

crypto: expose ECDH class

2018-02-12 19:28:06 -05:00

dgram.js

dgram: added setMulticastInterface()

2018-02-12 19:28:05 -05:00

dns.js

cluster, dns, repl, tls, util: fix RegExp nits

2017-07-21 14:35:04 -04:00

domain.js

test,lib,benchmark: match function names

2016-11-15 13:31:46 -05:00

events.js

lib: update indentation of ternaries

2017-09-05 12:49:50 -04:00

fs.js

fs: fix createReadStream(…, {end: n}) for non-seekable fds

2018-03-29 23:25:34 -04:00

http.js

lib,src: remove usage of events.EventEmitter

2015-09-23 00:23:08 +05:30

https.js

https: Use secureProtocol in Agent#getName

2017-11-14 13:44:54 -05:00

module.js

lib: enable dot-notation eslint rule

2018-02-27 00:01:59 -05:00

net.js

net: remove ADDRCONFIG DNS hint on Windows

2018-02-12 19:28:22 -05:00

os.js

os: improve loadavg() performance

2017-03-08 17:11:23 -08:00

path.js

path: fix path.normalize for relative paths

2018-02-27 00:25:10 -05:00

process.js

src: remove excessive license boilerplate

2015-01-27 16:35:05 +11:00

punycode.js

lib: remove let from for loops

2016-10-11 12:31:51 -04:00

querystring.js

url: adding WHATWG URL support

2018-02-12 19:28:11 -05:00

readline.js

readline: remove max limit of crlfDelay

2017-09-19 09:27:48 -04:00

repl.js

repl: improve require() autocompletion

2018-02-12 19:28:04 -05:00

stream.js

stream: move legacy to lib/internal dir

2017-03-08 17:10:53 -08:00

string_decoder.js

buffer,string_decoder: consolidate encoding validation logic

2016-09-13 16:13:09 -07:00

sys.js

util: introduce printDeprecationMessage function

2015-06-04 10:59:43 +03:00

timers.js

timers: fix eventloop block

2017-11-28 13:10:35 +09:00

tls.js

http, tls: better support for IPv6 addresses

2018-02-26 21:37:27 -05:00

tty.js

tty: refactor exports

2017-12-13 15:53:34 +00:00

url.js

url: adding WHATWG URL support

2018-02-12 19:28:11 -05:00

util.js

url: adding WHATWG URL support

2018-02-12 19:28:11 -05:00

v8.js

lib,src: support values > 4GB in heap statistics

2017-03-08 17:10:25 -08:00

vm.js

vm: refactor vm module

2017-03-08 17:10:34 -08:00

zlib.js

zlib: gracefully set windowBits from 8 to 9

2017-10-24 11:01:16 -04:00