Files
node/tools
Daniel Bevenius 9fd22bc4d4 build: fix ninja build failure (GYP patch)
Currently the files specified in libraries in node.gyp `cctest` target are
getting a '.lib' extension on windows when generated with ninja.
This commit adds a check to see if a file has a '.obj' extension and in
that case no '.lib' extension will be added.

Also, the LIBS specified in the 'libraries' section are not
being included in the --start-group --end-group section which
means that these libraries will not be searched causing issue
with linkers where the order matters.

PR-URL: https://github.com/nodejs/node/pull/12484
Fixes: https://github.com/nodejs/node/issues/12448
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-05-11 08:12:24 -04:00
..
2017-04-25 00:06:17 +03:00
2017-04-25 00:06:17 +03:00
2017-05-05 10:36:05 +02:00
2017-04-18 10:34:47 -07:00
2016-06-28 17:48:22 -04:00
2016-06-28 17:48:22 -04:00
2017-04-25 22:44:09 +03:00
2016-11-09 17:34:22 -05:00
2017-05-10 22:22:33 +02:00