Files
node/lib
Anna Henningsen e817c365ab fs: do not throw exception after creating FSReqCallback
Once an `FSReqCallback` instance is created, it is a GC root until
the underlying fs operation has completed, meaning that it cannot
be garbage collected.

This is a problem when the underlying operation never starts
because an exception is thrown before that happens, for example
as part of parameter validation.

Instead, move all potentially throwing code before the `FSReqCallback`
creation.

PR-URL: https://github.com/nodejs/node/pull/35487
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2020-10-06 10:31:09 +02:00
..
2020-05-24 03:26:21 +02:00
2020-02-18 22:15:50 -08:00
2020-09-15 15:39:54 -04:00
2020-09-04 10:51:13 +02:00
2020-06-19 07:40:11 -07:00
2020-06-19 17:37:26 +02:00
2020-04-28 19:10:26 +02:00
2019-12-11 16:38:06 -06:00
2020-08-10 12:09:43 -05:00
2020-05-16 06:42:16 +02:00