Files
node/tools
Sakthipriyan Vairamani (thefourtheye) 1d152b6e51 tools: prefer filter to remove empty strings
Ref: https://github.com/nodejs/node/pull/23585#issuecomment-430585490

Python's `list.remove` will throw if the element is not found and also
it removes only the first occurrence.

This patch replaces the use of `list.remove` with a `filter` which
solves both of the above mentioned problems.

PR-URL: https://github.com/nodejs/node/pull/23727
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-10-18 18:23:59 -04:00
..
2018-03-26 18:20:07 -04:00
2018-03-05 08:35:44 -06:00
2016-06-28 17:48:22 -04:00
2017-10-29 19:46:43 +01:00
2018-09-11 14:12:30 -04:00
2018-04-11 13:23:27 -04:00
2018-04-10 06:45:45 +09:00
2018-06-06 19:44:15 +02:00
2018-09-06 13:06:54 -07:00