Ruben Bridgewater a25f56730e assert: detect faulty throws usage ...

One of the biggest downsides to the `assert.throws` API is that it
does not check for the error message in case that is used as second
argument. It will instead be used in case no error is thrown.

This improves the situation by checking the actual error message
against the provided one and throws an error in case they are
identical. It is very unlikely that the user wants to use that error
message as information instead of checking against that message.

PR-URL: https://github.com/nodejs/node/pull/19867
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

2018-04-13 19:56:33 +02:00

..

fs

fs: refactor stats array to be more generic

2018-04-04 15:25:59 +08:00

internal

assert: detect faulty throws usage

2018-04-13 19:56:33 +02:00

_http_agent.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

_http_client.js

http: fix request when setHost is true

2018-04-03 15:43:40 -07:00

_http_common.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

_http_incoming.js

http: do not replace .read() in IncomingMessage

2018-02-27 12:26:40 +01:00

_http_outgoing.js

lib: improve error handling

2018-03-25 03:01:45 +02:00

_http_server.js

test,http: fix http dump test

2018-04-07 10:03:22 +02:00

_stream_duplex.js

net,stream: remove DuplexBase

2018-04-06 10:23:22 +02:00

_stream_passthrough.js

…

_stream_readable.js

stream: 'readable' have precedence over flowing

2018-04-06 13:50:15 +02:00

_stream_transform.js

stream: make virtual methods errors consistent

2018-03-12 14:24:34 +01:00

_stream_wrap.js

lib: move _stream_wrap into internals

2017-10-19 18:06:27 +02:00

_stream_writable.js

stream: give error message if write() cb called twice

2018-03-27 01:38:05 +01:00

_tls_common.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

_tls_wrap.js

tls: drop NPN (next protocol negotiation) support

2018-03-27 16:22:37 +02:00

.eslintrc.yaml

tools,lib: forbid native Error constructors

2018-03-21 20:15:33 +01:00

assert.js

assert: detect faulty throws usage

2018-04-13 19:56:33 +02:00

async_hooks.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

buffer.js

buffer: do not emit deprecation notice on Buffer.of

2018-04-10 21:37:57 -07:00

child_process.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

cluster.js

…

console.js

console: auto-detect color support by default

2018-04-12 23:23:57 +02:00

constants.js

src: add support to pass flags to dlopen

2017-09-08 17:14:03 -04:00

crypto.js

lib: port errors to new system

2018-03-05 19:51:30 +01:00

dgram.js

errors: improve SystemError messages

2018-04-05 04:46:26 +08:00

dns.js

errors: make dns errors consistent

2018-04-05 19:29:02 +02:00

domain.js

tools,lib: forbid native Error constructors

2018-03-21 20:15:33 +01:00

events.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

fs.js

fs: fix missing 'error' event in (Read|Write)Stream#destroy

2018-04-10 01:16:42 +02:00

http2.js

http2: refactor error handling

2017-08-28 00:39:42 +04:00

http.js

http: support server options on createServer

2018-03-25 11:51:32 +02:00

https.js

tls: drop NPN (next protocol negotiation) support

2018-03-27 16:22:37 +02:00

inspector.js

inspector: migrate errors from C++ to JS

2018-03-22 08:24:31 +01:00

module.js

lib: add back lib/module.js redirection

2018-03-15 20:50:35 +08:00

net.js

net,http2: merge write error handling & property names

2018-04-12 15:39:36 +02:00

os.js

errors: improve SystemError messages

2018-04-05 04:46:26 +08:00

path.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

perf_hooks.js

perf_hooks: simplify perf_hooks

2018-04-03 13:57:41 -07:00

process.js

…

punycode.js

…

querystring.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

readline.js

lib: port errors to new system

2018-03-05 19:51:30 +01:00

repl.js

lib: restructure cjs and esm loaders

2018-03-15 20:50:35 +08:00

stream.js

zlib,stream: use “official” util.types typechecks

2018-03-28 16:21:56 -07:00

string_decoder.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

sys.js

…

timers.js

lib: fix a typo in lib/timers "read through"

2018-03-28 20:10:19 -07:00

tls.js

tls: runtime-deprecate tls.convertNPNProtocols()

2018-03-27 16:22:37 +02:00

tty.js

errors: improve SystemError messages

2018-04-05 04:46:26 +08:00

url.js

tools: add 'spaced-comment' into eslint rules

2018-04-01 22:33:13 +08:00

util.js

util: introduce formatWithOptions()

2018-04-12 23:23:53 +02:00

v8.js

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25 01:45:37 +01:00

vm.js

vm: move options checks from C++ to JS

2018-04-03 17:59:22 +02:00

zlib.js

zlib: fix windowBits validation to allow 0 for decompression mode

2018-04-10 00:56:10 +02:00